sourcegraph/client
Erik Seliger 7568df08fa
chromatic: Fixup project detection and emit TurboSnap metadata with vite (#57494)
This fixes a few project metadata detection issues, makes it easier to run chromatic locally for testing, and potentially fixes TurboSnap with vite.
2023-10-09 22:56:52 +02:00
..
app-shell remove unused/unneeded esbuild plugins (#57408) 2023-10-06 07:55:29 +00:00
branded search: Refactor CodeMirror query input (part 2) (#57382) 2023-10-09 16:08:52 +02:00
browser use esbuild for browser extension builds (#57231) 2023-10-08 14:18:52 +09:00
build-config use esbuild for browser extension builds (#57231) 2023-10-08 14:18:52 +09:00
client-api Eslint fix type imports (#54920) 2023-08-10 21:12:31 +02:00
codeintellify Eslint fix type imports (#54920) 2023-08-10 21:12:31 +02:00
cody remove cody code that was moved to separate cody repo (#54729) 2023-07-10 00:31:47 -10:00
cody-jetbrains JetBrains plugin: merge Sourcegraph and Cody (#52706) 2023-06-01 12:43:11 +02:00
common Eslint fix type imports (#54920) 2023-08-10 21:12:31 +02:00
eslint-plugin-wildcard bazel: implement custom ESLint Bazel rule (#52062) 2023-05-22 04:05:45 -07:00
extension-api remove client/extension-api stub (#57451) 2023-10-08 14:05:20 +09:00
extension-api-types Eslint fix type imports (#54920) 2023-08-10 21:12:31 +02:00
http-client Revert progress made on "Enhanced admin onboarding" (#56239) 2023-09-01 16:06:25 -05:00
jetbrains search: Refactor CodeMirror query input (part 2) (#57382) 2023-10-09 16:08:52 +02:00
observability-client Eslint fix type imports (#54920) 2023-08-10 21:12:31 +02:00
observability-server rename {webpack => web}.manifest.json (#57449) 2023-10-07 14:02:41 -10:00
shared search: Refactor CodeMirror query input (part 2) (#57382) 2023-10-09 16:08:52 +02:00
storybook chromatic: Fixup project detection and emit TurboSnap metadata with vite (#57494) 2023-10-09 22:56:52 +02:00
template-parser Eslint fix type imports (#54920) 2023-08-10 21:12:31 +02:00
testing Revert "revert "bazel: improve ESLint rule" (#52853)" (#52878) 2023-06-04 19:06:39 -07:00
vscode use esbuild for building client/vscode (#57447) 2023-10-08 14:05:37 +09:00
web Verify signup and login pages in chromatic (#57493) 2023-10-09 16:43:01 -04:00
web-sveltekit migrate to storybook 7 (#57437) 2023-10-07 21:55:42 +00:00
wildcard globally disable the id-length rule (long live vars named i) (#57452) 2023-10-09 06:12:05 +09:00
BUILD.bazel sveltekit: Add support for feature flags (and improve testing) (#55474) 2023-08-01 13:44:22 +02:00
README.md [SG-46115] - Merge the search-ui package into the branded package (#46197) 2023-01-11 18:27:19 +01:00

Frontend packages

List

  • web: The web application deployed to http://sourcegraph.com/
  • browser: The Sourcegraph browser extension adds tooltips to code on different code hosts.
  • vscode: The Sourcegraph VS Code extension.
  • extension-api: The Sourcegraph extension API types for the Sourcegraph extensions. Published as sourcegraph.
  • extension-api-types: The Sourcegraph extension API types for client applications that embed Sourcegraph extensions and need to communicate with them. Published as @sourcegraph/extension-api-types.
  • sandboxes: All demos-mvp (minimum viable product) for the Sourcegraph web application.
  • shared: Contains common TypeScript/React/SCSS client code shared between the browser extension and the web app. Everything in this package is code-host agnostic.
  • branded: Contains React components and implements the visual design language we use across our web app and e.g. in the options menu of the browser extension. Over time, components from shared and branded packages should be moved into the wildcard package.
  • wildcard: Package that encapsulates storybook configuration and contains our Wildcard design system components. If we're using a component in two or more different areas (e.g. web-app and browser-extension) then it should live in the wildcard package. Otherwise the components should be better colocated with the code where they're actually used.
  • search: Search-related code that may be shared between all clients, both branded (e.g. web, VS Code extension) and unbranded (e.g. browser extension)
  • storybook: Storybook configuration.

Further migration plan

  1. Fix circular dependency in TS project-references graph wildcard package should not rely on web and probably shared, branded too. Ideally it should be an independent self-contained package.

  2. Decide on package naming and update existing package names. Especially it should be done for a shared package because we have multiple shared folders inside of other packages. It's hard to understand from where dependency is coming from and it's not possible to refactor import paths using find-and-replace.

  3. Investigate if we can painlessly switch to npm workspaces.

  4. Content of packages shared and branded should be moved to wildcard and refactored using the latest FE rules and conventions. Having different packages clearly communicates the migration plan. Developers first should look for components in the wildcard package and then fall-back to legacy packages if wildcard doesn't have the solution to their problem yet.

  5. shared contains utility functions, types, polyfills, etc which is not a part of the Wildcard component library. These modules should be moved into utils package and other new packages: e.g. api for GraphQL client and type generators, etc.

  6. Packages should use package name (e.g. @sourcegraph/wildcard) for imports instead of the relative paths (e.g. ../../../../wildcard/src/components/Markdown) to avoid long relative-paths and make dependency graph between packages clear. (Typescript will warn if packages have circular dependencies). It's easy to refactor such isolated packages, extract functionality into new ones, or even into new repositories.

  7. build or config package should be added later to encapsulate all the configurations reused between packages which will allow removing jest.config, babel.config from the root of the repo.