mirror of
https://github.com/sourcegraph/sourcegraph.git
synced 2026-02-06 20:11:54 +00:00
908d7119ea
Deleting Notion pages takes a very long time, and is prone to breaking in the page deletion step, where we must delete blocks one at a time because Notion does not allow for bulk block deletions. The errors seem to generally just be random Notion internal errors. This is very bad because it leaves go/msp-ops pages in an unusable state. To try and mitigate, we add several places to blindly retry: 1. At the Notion SDK level, where a config option is available for retrying 429 errors 2. At the "reset page" helper level, where a failure to reset a page will prompt a retry of the whole helper 3. At the "delete blocks" helper level, where individual block deletion failures will be retried Attempt to mitigate https://linear.app/sourcegraph/issue/CORE-119 While here, I also made some other QOL tweaks: - Fix timing of sub-tasks in CLI output - Bump default concurrency to 5 (our retries will handle if this is too aggressive, hopefully) - Fix a missing space in generated docs ## Test plan ``` sg msp ops generate-handbook-pages ``` |
||
|---|---|---|
| .. | ||
| diagram | ||
| internal/markdown | ||
| terraform | ||
| testdata | ||
| BUILD.bazel | ||
| index_test.go | ||
| index.go | ||
| links.go | ||
| notion.go | ||
| operationdocs_test.go | ||
| operationdocs.go | ||