artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 15:31:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
56e1f11f25
sourcegraph/client/shared
History
Felix Kling 9890086f94
fix(web): Show 'Find implementation' button for languages that support it (#64440) 
Fixes srch-882

I noticed that the button wasn't shown anymore (neither in Svelte nor in
React). It seems that this broke when we switched from using the file
extension to getting the language(s) from the server.
The server sends back capitalized names which we compare against
lowercase IDs.

If there there is a new/modern way to find out whether a language
support 'find implementation' or not, please let me know. For the time
being this seems to be a simple fix to get it working again like it
before. Alternatively we can also compare the stylized name.

## Test plan

Hovering over a Go interface (e.g.
https://sourcegraph.sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/internal/conf/server.go?L12)
shows the 'find implementations' button in the hovercard again)
2024-08-13 15:40:03 +02:00
..
dev chore(ci): remove Percy visual tests (#63515) 2024-06-27 16:20:06 +02:00
src fix(web): Show 'Find implementation' button for languages that support it (#64440) 2024-08-13 15:40:03 +02:00
.bazelignore bazel: remove schema.ts entries (#48976) 2023-03-08 20:25:29 -08:00
.eslintignore bazel: remove schema.ts entries (#48976) 2023-03-08 20:25:29 -08:00
.stylelintrc.json web: integrate @sourcegraph/stylelint-plugin-sourcegraph and ban bootstrap imports (#34956) 2022-05-05 04:27:26 +00:00
BUILD.bazel chore(svelte): Cleanup dependencies (#63691) 2024-07-08 17:54:44 +02:00
NOTICE
package.json feat/dotcom: use Enterprise Portal for Cody Gateway usage (#63653) 2024-07-10 19:22:08 +00:00
README.md web: drop bootstrap depenedency (#41401) 2022-09-07 03:11:26 -07:00
tsconfig.json reapply "switch from jest to vitest for faster, simpler tests (#57886)" (#58145) 2023-11-07 12:00:18 +02:00
vitest.config.ts reapply "switch from jest to vitest for faster, simpler tests (#57886)" (#58145) 2023-11-07 12:00:18 +02:00

README.md

Shared

This folder contains common TypeScript/React/SCSS client code shared between the browser extension and the web app.

Everything in this folder is code-host agnostic and cannot make assumptions about whether it is running inside the Sourcegraph web app, in the browser extension on GitHub, Gitlab, Phabricator, Bitbucket Server, etc. In particular, components cannot make use of global CSS classes but must accept CSS classes as props and/or have their own code host agnostic SCSS stylesheets. For more details, see Styling UI in the handbook.

Code that is only used in branded contexts (web app, options menu of the browser extension, ...) should go into ../branded instead.