sourcegraph/client
Jason Bedard 3eb718dcd9
build: move build-config specific dependencies to build-config/package.json (#48072)
Other packages within `client/*` depend on `@sourcegraph/build-config`
as a dev dependency, but `@sourcegraph/build-config` itself depends on
these as runtime dependencies. Under bazel this dev vs non-dev is
stricter and `build-config` needs to declare the dependencies correctly.

Some of the deps are still in the root package.json as dev-deps when
they are still used elsewhere, others were removed from the root and are
now only in `build-config`.
2023-02-22 19:25:07 -08:00
..
backstage-backend backstage frontend scaffolding building with es (#47722) 2023-02-16 15:18:39 +02:00
backstage-frontend backstage frontend scaffolding building with es (#47722) 2023-02-16 15:18:39 +02:00
branded own: basic person search result (#47214) 2023-02-22 16:19:25 -08:00
browser Remove ThemeProps and add new theme state logic (#47864) 2023-02-22 13:28:47 -03:00
build-config build: move build-config specific dependencies to build-config/package.json (#48072) 2023-02-22 19:25:07 -08:00
client-api web: fix pnpm-lock issue (#47478) 2023-02-09 22:04:31 -08:00
codeintellify web: fix pnpm-lock issue (#47478) 2023-02-09 22:04:31 -08:00
common web: upgrade react-router to v6 (#47595) 2023-02-21 06:32:51 +00:00
eslint-plugin-wildcard Backstage: add scaffolding (#46634) 2023-01-20 10:12:14 +00:00
extension-api web: fix pnpm-lock issue (#47478) 2023-02-09 22:04:31 -08:00
extension-api-types web: fix pnpm-lock issue (#47478) 2023-02-09 22:04:31 -08:00
http-client Update to Apollo 3.8 (#47833) 2023-02-21 12:13:32 +01:00
jetbrains Remove ThemeProps and add new theme state logic (#47864) 2023-02-22 13:28:47 -03:00
observability-client web: fix pnpm-lock issue (#47478) 2023-02-09 22:04:31 -08:00
observability-server web: fix pnpm-lock issue (#47478) 2023-02-09 22:04:31 -08:00
shared own: basic person search result (#47214) 2023-02-22 16:19:25 -08:00
storybook web: fix pnpm-lock issue (#47478) 2023-02-09 22:04:31 -08:00
template-parser web: fix pnpm-lock issue (#47478) 2023-02-09 22:04:31 -08:00
testing web: fix pnpm-lock issue (#47478) 2023-02-09 22:04:31 -08:00
vscode Remove ThemeProps and add new theme state logic (#47864) 2023-02-22 13:28:47 -03:00
web own: basic person search result (#47214) 2023-02-22 16:19:25 -08:00
web-sveltekit [experiment] Merge SvelteKit prototype into main (#47238) 2023-02-13 17:53:23 +01:00
wildcard Fix wildcard tooltip making <svg> elements appear in tab order (#48052) 2023-02-22 23:41:47 +01:00
BUILD.bazel bazel: move general purpose rules to dev/defs.bzl (#45792) 2022-12-19 10:40:37 +01:00
README.md [SG-46115] - Merge the search-ui package into the branded package (#46197) 2023-01-11 18:27:19 +01:00

Frontend packages

List

  • web: The web application deployed to http://sourcegraph.com/
  • browser: The Sourcegraph browser extension adds tooltips to code on different code hosts.
  • vscode: The Sourcegraph VS Code extension.
  • extension-api: The Sourcegraph extension API types for the Sourcegraph extensions. Published as sourcegraph.
  • extension-api-types: The Sourcegraph extension API types for client applications that embed Sourcegraph extensions and need to communicate with them. Published as @sourcegraph/extension-api-types.
  • sandboxes: All demos-mvp (minimum viable product) for the Sourcegraph web application.
  • shared: Contains common TypeScript/React/SCSS client code shared between the browser extension and the web app. Everything in this package is code-host agnostic.
  • branded: Contains React components and implements the visual design language we use across our web app and e.g. in the options menu of the browser extension. Over time, components from shared and branded packages should be moved into the wildcard package.
  • wildcard: Package that encapsulates storybook configuration and contains our Wildcard design system components. If we're using a component in two or more different areas (e.g. web-app and browser-extension) then it should live in the wildcard package. Otherwise the components should be better colocated with the code where they're actually used.
  • search: Search-related code that may be shared between all clients, both branded (e.g. web, VS Code extension) and unbranded (e.g. browser extension)
  • storybook: Storybook configuration.

Further migration plan

  1. Fix circular dependency in TS project-references graph wildcard package should not rely on web and probably shared, branded too. Ideally it should be an independent self-contained package.

  2. Decide on package naming and update existing package names. Especially it should be done for a shared package because we have multiple shared folders inside of other packages. It's hard to understand from where dependency is coming from and it's not possible to refactor import paths using find-and-replace.

  3. Investigate if we can painlessly switch to npm workspaces.

  4. Content of packages shared and branded should be moved to wildcard and refactored using the latest FE rules and conventions. Having different packages clearly communicates the migration plan. Developers first should look for components in the wildcard package and then fall-back to legacy packages if wildcard doesn't have the solution to their problem yet.

  5. shared contains utility functions, types, polyfills, etc which is not a part of the Wildcard component library. These modules should be moved into utils package and other new packages: e.g. api for GraphQL client and type generators, etc.

  6. Packages should use package name (e.g. @sourcegraph/wildcard) for imports instead of the relative paths (e.g. ../../../../wildcard/src/components/Markdown) to avoid long relative-paths and make dependency graph between packages clear. (Typescript will warn if packages have circular dependencies). It's easy to refactor such isolated packages, extract functionality into new ones, or even into new repositories.

  7. build or config package should be added later to encapsulate all the configurations reused between packages which will allow removing jest.config, babel.config from the root of the repo.