artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 20:11:54 +00:00
Code Issues Packages Projects Releases Wiki Activity
3d36d34b3d
sourcegraph/dev
History
Jean-Hadrien Chabran 3d36d34b3d
ci: re-enable race detection (#52776) 
The previous approach to enable race detection was too radical and
accidently led to build our binaries with the race flage enabled, which
caused issues when building images down the line.

This happened because putting a `test --something` in bazelrc also sets
it on `build` which is absolutely not what we wanted. Usually folks get
this one working by having a `--stamp` config setting that fixes this
when releasing binaries, which we don't at this stage, as we're still
learning Bazel.

Luckily, this was caught swiftly. The current approach insteads takes a
more granular approach, which makes the `go_test` rule uses our own
variant, which injects the `race = "on"` attribute, but only on
`go_test`.


## Test plan

<!-- All pull requests REQUIRE a test plan:
https://docs.sourcegraph.com/dev/background-information/testing_principles
-->

CI, being a main-dry-run, this will cover the container building jobs,
which were the ones failing.

---------

Co-authored-by: Alex Ostrikov <alex.ostrikov@sourcegraph.com>
2023-06-05 20:41:47 +02:00
..
adr-docs bazel: introduce build files for Go (#46770) 2023-01-23 14:00:01 +01:00
auth-provider Remove left-over mentions of dev/start.sh (#25745) 2021-10-07 16:38:00 +02:00
authtest ci: re-enable race detection (#52776) 2023-06-05 20:41:47 +02:00
backcompat Switch to OCI/Wolfi based image (#52693) 2023-06-02 12:12:52 +02:00
bkstats bazel: introduce build files for Go (#46770) 2023-01-23 14:00:01 +01:00
build-tracker ci: re-enable race detection (#52776) 2023-06-05 20:41:47 +02:00
buildchecker ci: re-enable race detection (#52776) 2023-06-05 20:41:47 +02:00
check ci: improve pnpm dedupe CI check (#52741) 2023-06-01 06:02:20 +00:00
ci ci: re-enable race detection (#52776) 2023-06-05 20:41:47 +02:00
codeintel-qa Switch to OCI/Wolfi based image (#52693) 2023-06-02 12:12:52 +02:00
corrupt-archives bazel: introduce build files for Go (#46770) 2023-01-23 14:00:01 +01:00
db dev/deb: Remove scripts replaced by sg (#28767) 2021-12-08 23:22:00 +00:00
depgraph Update buildfiles + fix analysis (#50013) 2023-03-27 12:11:46 +02:00
dx bazel: build //enterprise (#47327) 2023-02-07 15:30:46 +01:00
gqltest ci: re-enable race detection (#52776) 2023-06-05 20:41:47 +02:00
grafana dev/sg: introduce 'sg ci logs' with Loki support (#25835) 2021-10-12 11:14:50 -04:00
internal/cmd ci: re-enable race detection (#52776) 2023-06-05 20:41:47 +02:00
linters bazel: add unparam nogo linter (#50730) 2023-04-18 10:03:35 +00:00
nix nix: fix bazel test (#52939) 2023-06-05 18:33:27 +02:00
perforce ci: re-enable race detection (#52776) 2023-06-05 20:41:47 +02:00
perforce-testing-helpers ci: update the use of perforce.sgdev to perforce-tests.sgdev (#50664) 2023-04-17 17:42:28 -07:00
phabricator web: migrate from yarn to pnpm (#46143) 2023-01-11 19:50:09 -08:00
pr-auditor ci: re-enable race detection (#52776) 2023-06-05 20:41:47 +02:00
prometheus Switch to OCI/Wolfi based image (#52693) 2023-06-02 12:12:52 +02:00
release release: prepare 5.0.6 (#52837) 2023-06-02 20:26:02 +02:00
scaletesting ci: re-enable race detection (#52776) 2023-06-05 20:41:47 +02:00
sg ci: re-enable race detection (#52776) 2023-06-05 20:41:47 +02:00
src-expose ci: re-enable race detection (#52776) 2023-06-05 20:41:47 +02:00
team bazel: introduce build files for Go (#46770) 2023-01-23 14:00:01 +01:00
tilt Remove left-over mentions of dev/start.sh (#25745) 2021-10-07 16:38:00 +02:00
zoekt zoekt: set -indexserver_proxy for webserver (#44995) 2022-12-02 08:38:44 +01:00
.gitignore
add_https_domain_to_hosts.sh
babel.bzl bazel: rename arg to follow convention (#50627) 2023-04-14 04:46:45 +00:00
bazel_buildkite_stamp_vars.sh bazel: test volatile variables with Percy (#51693) 2023-05-11 09:20:42 +00:00
bazel_stamp_vars.sh bzl: fix missing year digits when stamping (#52917) 2023-06-05 10:32:06 +00:00
BUILD.bazel Revert "revert "bazel: improve ESLint rule" (#52853)" (#52878) 2023-06-04 19:06:39 -07:00
caddy.sh Bump caddy version (#26329) 2021-10-19 22:06:22 +00:00
Caddyfile dev/Caddyfile: use 127.0.0.1 instead of localhost (#38955) 2022-07-18 13:19:09 -07:00
CLA.txt
codecov.yml vscode: ignore vscode in Codecov (#32676) 2022-03-16 11:28:28 -04:00
codeinsights-db.sh insights: update references to TimescaleDB (#32948) 2022-03-29 11:04:47 +01:00
comby-install-or-upgrade.sh update team reviewers (#50119) 2023-04-03 16:36:12 +02:00
ctags-install.sh dev: add installer script for building a local universal-ctag (#45198) 2022-12-06 18:32:21 +01:00
defs.bzl Revert "revert "bazel: improve ESLint rule" (#52853)" (#52878) 2023-06-04 19:06:39 -07:00
dev-sourcegraph-server.sh
docsite.sh doc: fix bad and broken links (#51902) 2023-05-12 17:57:43 -04:00
drop-entire-local-database-and-redis.sh
eslint-report-test.sh Revert "revert "bazel: improve ESLint rule" (#52853)" (#52878) 2023-06-04 19:06:39 -07:00
eslint.bzl bzl: fix warnings on eslint tests w/ timeout=short (#52923) 2023-06-05 14:40:27 +02:00
foreach-non-web-client-project.sh Cody: Add E2E test setup based on Playwright (#52071) 2023-05-19 19:11:52 +02:00
git-stats search: create and document git-stats script (#32663) 2022-03-16 13:41:17 +02:00
global-settings.json codeintel: Revive braindot (#49128) 2023-03-13 13:33:39 +00:00
go_defs.bzl ci: re-enable race detection (#52776) 2023-06-05 20:41:47 +02:00
go-mod-update.sh
js_lib.bzl bazel: implement custom ESLint Bazel rule (#52062) 2023-05-22 04:05:45 -07:00
licenses.sh rework plugin structure and implement frontside blogpost (#46883) 2023-02-15 11:49:51 +02:00
mocha.bzl bazel: make percy silent on success (#52906) 2023-06-04 23:16:05 -07:00
oci_defs.bzl Switch to OCI/Wolfi based image (#52693) 2023-06-02 12:12:52 +02:00
oci_deps.bzl Switch to OCI/Wolfi based image (#52693) 2023-06-02 12:12:52 +02:00
postgres_exporter.sh migrations: Update postgres exporter queries for dirty database (#30774) 2022-02-10 17:40:09 -06:00
proto.bzl fix: gazelle and proto generation (continuation of #49547) (#49713) 2023-04-11 11:36:45 +02:00
prune-pick.sh
redis-postgres.yml Update Postgres to 12.7 (#31933) 2022-03-03 14:39:52 -06:00
redis.conf
run-server-image.sh Switch to OCI/Wolfi based image (#52693) 2023-06-02 12:12:52 +02:00
sass.bzl Buildifier fixes (#48691) 2023-03-07 10:15:26 +01:00
scip-ctags-dev syntax-highlighter: initial ctags work (w/ musl scip-ctags) (#52643) 2023-05-30 17:19:39 -04:00
scip-ctags-install.sh syntax-highlighter: initial ctags work (w/ musl scip-ctags) (#52643) 2023-05-30 17:19:39 -04:00
site-config.json Always disable user external service mode in UI (#44721) 2022-11-23 14:49:03 +01:00
src-prof-services.json Add embeddings to server behind env var (#50288) 2023-04-04 16:45:50 +02:00
src-search-meta.sh GraphQL: remove deprecated resultCount field (#31573) 2022-02-21 12:03:36 -07:00
tools.go cody-gateway: rename service from LLM-proxy (#52565) 2023-05-30 08:44:27 -07:00
universal-ctags-dev dev: add installer script for building a local universal-ctag (#45198) 2022-12-06 18:32:21 +01:00
webpack.bzl bazel: test bundlesize report ts (#50847) 2023-04-27 19:11:06 -07:00