mirror of
https://github.com/sourcegraph/sourcegraph.git
synced 2026-02-06 19:51:50 +00:00
f5afeb8c22
Closes https://linear.app/sourcegraph/issue/CORE-199. AIP generally implies `Update` RPCs are authoritative, which means that we should be deleting all roles memberships not provided to `UpdateEnterpriseSubscriptionMembership`. Most important outcome here is that we can actually remove roles from users by assigning them an empty role set `[]` Later we can add a "get roles" RPC to safely make these updates, and introduce a purely additive RPC if needed. It's not a huge deal right now because we only have 1 role ("customer admin") Also removes the deprecated value from https://github.com/sourcegraph/sourcegraph/pull/63501. ## Test plan Unit tests, expanded with better table-driven cases and expanded assertions |
||
|---|---|---|
| .. | ||
| bigquerywriter | ||
| cloudsql | ||
| iam | ||
| runtime | ||
| BUILD.bazel | ||
| go.mod | ||
| go.sum | ||
| managedservicesplatform.go | ||