artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 20:11:54 +00:00
Code Issues Packages Projects Releases Wiki Activity
06262e0936
sourcegraph/dev
History
Noah S-C 06262e0936
bazel: patches to allow use_default_shell_env for e2e testing (#59675) 
Another step towards https://github.com/sourcegraph/sourcegraph/issues/59155, previously `bazel test //...` would error at analysis time on `//client/web/src/end-to-end:e2e` due to it attempting to perform variable substitution for env vars e.g. `"HEADLESS": "$(E2E_HEADLESS)"`, for values not defined via `--define` (we only set these explicitly in .aspect/bazelrc/ci.sourcegraph.bazelrc and some `sg` targets).

By leveraging https://bazel.build/rules/lib/builtins/actions#run.use_default_shell_env, we can allow the test to read values from `--action_env` while _also_ having explicit values set via `env` macro parameter. Previously, setting `env` macro parameter would completely shadow any `--action_env` values. 
Unfortunately, we cant use `--test_env` for this, as `js_run_binary` is an action not a test (or something like that?).

We also cant do env renaming anymore, meaning we have to drop the `E2E_` prefix for some env vars. At least one script needed some reworking to accommodate that `e2e_test.sh` 

![image](https://github.com/sourcegraph/sourcegraph/assets/18282288/133a98c6-411d-4a10-95fd-4abd42cedb24)


## Test plan

👁️ CI once again 👁️
2024-01-24 18:50:19 -08:00
..
auth-provider remove more ENTERPRISE=1 remnants (#57232) 2023-10-02 10:43:11 -07:00
authtest Implement expiry for access tokens (#59565) 2024-01-18 18:54:07 -05:00
backcompat database: make gitserver_repos_statistics append-only (#58496) 2023-11-23 15:36:58 +01:00
bkstats chore: links/ownership devx->dev-infra (#58999) 2023-12-14 15:07:20 +00:00
build-tracker build-tracker: only account for terminal job states (#58834) 2023-12-08 15:40:47 +02:00
buildchecker dev: remove deadlink from buildchecker (#59118) 2023-12-20 09:50:07 +00:00
check Batch indexing: syntactic codeintel worker scaffolding (#59747) 2024-01-24 13:04:20 +00:00
ci ci: drop unused operation (#59661) 2024-01-18 12:04:01 +01:00
clustering Dev tool: python script for text clustering based on local embeddings (#58691) 2023-12-04 09:27:14 -05:00
codehost_testing e2e test: define base tst framework for easier scenario setup (#56774) 2023-10-10 16:30:00 +02:00
codeintel-qa Uses src code-intel over the deprecated src lsif (#59577) 2024-01-15 11:45:56 +01:00
corrupt-archives bazel: introduce build files for Go (#46770) 2023-01-23 14:00:01 +01:00
db
depgraph remove more remannts of OSS build (#58253) 2023-11-10 07:59:03 +00:00
deployment-lag-notifier Chore: move dev tools out of enterprise (#57354) 2023-10-04 22:56:50 +02:00
deployment-notifier chore: links/ownership devx->dev-infra (#58999) 2023-12-14 15:07:20 +00:00
dx bazel: build //enterprise (#47327) 2023-02-07 15:30:46 +01:00
gqltest Implement expiry for access tokens (#59565) 2024-01-18 18:54:07 -05:00
grafana
insight-data-gen Chore: move dev tools out of enterprise (#57354) 2023-10-04 22:56:50 +02:00
internal/cmd Remove App from codebase (#59115) 2023-12-21 01:07:05 +01:00
linters Batch indexing: syntactic codeintel worker scaffolding (#59747) 2024-01-24 13:04:20 +00:00
managedservicesplatform sg/msp: fix monitoring config struct always being zero value (#59769) 2024-01-23 11:52:21 -08:00
nix nix: patch bazel_7 with hardcoded bin paths (#59359) 2024-01-16 20:58:22 +00:00
perforce perforce: move perforce test helpers to perforce dir (#57700) 2023-10-18 16:13:03 +02:00
phabricator add shellcheck & shfmt to pre-commit's pre-push hook (#59485) 2024-01-11 14:16:22 +00:00
pr-auditor Removed pr-auditor and left redirect notice (#59497) 2024-01-10 15:15:24 -08:00
prometheus telemetry-gateway: migrate to MSP runtime (#58814) 2023-12-08 12:14:34 -08:00
release release template update (#59831) 2024-01-24 19:31:06 +00:00
scaletesting chore: links/ownership devx->dev-infra (#58999) 2023-12-14 15:07:20 +00:00
sg sg ops: add shell kind to update-images (#59692) 2024-01-19 10:20:20 +02:00
src-expose ci: re-enable race detection (#52776) 2023-06-05 20:41:47 +02:00
team [chore] Use consistent go-github versioning (#57391) 2023-10-06 10:48:18 +02:00
tilt
tools Port executors building/pushing scripts to use Bazel (#58892) 2023-12-20 18:33:49 +00:00
update-embeddings-list reapply "switch from jest to vitest for faster, simpler tests (#57886)" (#58145) 2023-11-07 12:00:18 +02:00
zoekt update zoekt to include updated grpc prometheus 2.0.0 version (#56735) 2023-09-18 19:51:59 +00:00
.gitignore
add_https_domain_to_hosts.sh
bazel_buildkite_stamp_vars.sh bazel: test volatile variables with Percy (#51693) 2023-05-11 09:20:42 +00:00
bazel_stamp_vars.sh [backport] bzl: use old method for getting VERSION stamping (#53959) 2023-06-22 17:45:04 +02:00
BUILD.bazel bzl: handle stitched migration graph generation (#59378) 2024-01-09 11:39:50 +01:00
caddy.sh fix(sg): start Caddy admin server before caddy trust (#58928) 2023-12-20 10:03:45 +02:00
Caddyfile Add an option for disabling HTTP/2 when communicating with Cody Gateway (#59668) 2024-01-17 15:36:40 +01:00
check-tokens.sh local: handle exceptions for token checking pre-commit hook (#57856) 2023-10-24 12:32:54 +00:00
CLA.txt
codeinsights-db.sh insights: update references to TimescaleDB (#32948) 2022-03-29 11:04:47 +01:00
comby-install-or-upgrade.sh add shellcheck & shfmt to pre-commit's pre-push hook (#59485) 2024-01-11 14:16:22 +00:00
defs.bzl build: add buildifier check to Aspect Workflows (#58566) 2023-11-27 14:58:01 +02:00
dev-sourcegraph-server.sh
docsite.sh [docsite]: bump version (#56013) 2023-08-18 12:40:44 -06:00
drop-entire-local-database-and-redis.sh
esbuild.bzl Revert "use vite for web builds (#58228)" (#59132) 2023-12-20 16:23:45 -03:00
eslint-report-test.sh Revert "revert "bazel: improve ESLint rule" (#52853)" (#52878) 2023-06-04 19:06:39 -07:00
eslint.bzl reapply "switch from jest to vitest for faster, simpler tests (#57886)" (#58145) 2023-11-07 12:00:18 +02:00
foreach-non-web-client-project.sh remove cody code that was moved to separate cody repo (#54729) 2023-07-10 00:31:47 -10:00
git-stats search: create and document git-stats script (#32663) 2022-03-16 13:41:17 +02:00
global-settings.json dev: revert to old search mode for local dev environment (#59129) 2023-12-20 17:02:32 +01:00
go_defs.bzl build: add buildifier check to Aspect Workflows (#58566) 2023-11-27 14:58:01 +02:00
go_stringer.bzl build: upgrade to Bazel 7 pre-release (#57970) 2023-10-31 15:29:14 +02:00
go-mod-update.sh
js_lib.bzl bazel: implement custom ESLint Bazel rule (#52062) 2023-05-22 04:05:45 -07:00
licenses.sh add shellcheck & shfmt to pre-commit's pre-push hook (#59485) 2024-01-11 14:16:22 +00:00
migrations.bzl build: add buildifier check to Aspect Workflows (#58566) 2023-11-27 14:58:01 +02:00
mocha.bzl bazel: patches to allow use_default_shell_env for e2e testing (#59675) 2024-01-24 18:50:19 -08:00
oci_defs.bzl build: add buildifier check to Aspect Workflows (#58566) 2023-11-27 14:58:01 +02:00
oci_deps.bzl update images hashes (#58806) 2023-12-06 17:33:37 +02:00
p4-fusion-dev bazel: provide p4-fusion via bazel (#58893) 2023-12-11 16:06:06 +00:00
proto.bzl fix: gazelle and proto generation (continuation of #49547) (#49713) 2023-04-11 11:36:45 +02:00
prune-pick.sh
redis-postgres.yml Update Postgres to 12.7 (#31933) 2022-03-03 14:39:52 -06:00
redis.conf
run-server-image.sh Remove HTTP for inter-service RPC (#59093) 2024-01-11 19:46:32 +01:00
sass.bzl Buildifier fixes (#48691) 2023-03-07 10:15:26 +01:00
scip-ctags-dev local: fix scip-ctags install script (#57252) 2023-10-02 14:58:14 +00:00
scip-ctags-install.sh syntax-highlighter: initial ctags work (w/ musl scip-ctags) (#52643) 2023-05-30 17:19:39 -04:00
scip-treesitter-dev Batch indexing: syntactic codeintel worker scaffolding (#59747) 2024-01-24 13:04:20 +00:00
scip-treesitter-install.sh Batch indexing: syntactic codeintel worker scaffolding (#59747) 2024-01-24 13:04:20 +00:00
site-config.json Remove broken federation feature (#55161) 2023-07-20 17:30:32 +00:00
src-prof-services.json Add embeddings to server behind env var (#50288) 2023-04-04 16:45:50 +02:00
src-search-meta.sh GraphQL: remove deprecated resultCount field (#31573) 2022-02-21 12:03:36 -07:00
tool_deps.bzl Port executors building/pushing scripts to use Bazel (#58892) 2023-12-20 18:33:49 +00:00
tools.go doc/telemetry: add exported events schema (#57106) 2023-09-28 13:51:44 -07:00
universal-ctags-dev bzl: do not show full commmand line for ctags in dev (#58261) 2023-11-10 10:05:25 -05:00
write_generated_to_source_files.bzl build: add buildifier check to Aspect Workflows (#58566) 2023-11-27 14:58:01 +02:00