mirror of
https://github.com/sourcegraph/sourcegraph.git
synced 2026-02-06 14:31:56 +00:00
4d6e8949e8
Closes SRCH-802 After a long and unsuccessful hunt of eventual consistency errors, I noticed that we don't need the GraphQL fragments that are causing problems. I introduced a simplified request, which succeeds reliably. What customers should see now is one error (see second picture below), which is followed by a retry, and then success. Previously we've seen this error, sometimes less often, sometimes more, but customers saw it so often that it caused their batch changes to fail. <img width="1042" alt="Screenshot 2024-08-06 at 14 02 00" src="https://github.com/user-attachments/assets/c5a099da-d474-43db-ac12-ac7c4f22d4d3"> Customers may still see an initial error, which I've seen to reliably disappear on the first retry. It should not be a problem <img width="1039" alt="Screenshot 2024-08-06 at 14 02 48" src="https://github.com/user-attachments/assets/99f278d4-4020-48ea-b4ac-32cbdfce455d"> ## Test plan Manual testing ## Changelog - fix(batches): improve GitHub Apps integration reliability by simplifying the data requested from GitHub |
||
|---|---|---|
| .. | ||
| global | ||
| graphql | ||
| processor | ||
| reconciler | ||
| rewirer | ||
| scheduler | ||
| search | ||
| service | ||
| sources | ||
| state | ||
| store | ||
| syncer | ||
| testing | ||
| types | ||
| webhooks | ||
| background.go | ||
| BUILD.bazel | ||
| CODENOTIFY | ||
| conf.go | ||
| doc.go | ||