mirror of
https://github.com/sourcegraph/sourcegraph.git
synced 2026-02-06 20:51:43 +00:00
b2e550c8e5
During an investigation, we saw that Rockskip was not using scip-ctags for symbol parsing when applicable. This means that 1. Rockskip is getting less than optimal symbols for certain languages (like Go) 2. Rockskip is getting no symbols for languages not in universal ctags (Magik) This PR attempts to solve this problem but updating Rockskip to re-use the ctags parser pool logic from symbol service. ### Key Changes - Update parser pool to be re-usable - Push common logic for parser type detection into the parser pool module - Update rockskip service config to take a parser pool - Update and add unit/integration tests ## Questions - What performance impact will using this pooled parser have compared to its previous behavior of spawning a new ctags process each time? ## Test plan - [x] Add unit tests - [x] Update integration tests - [x] Manually test rockskip - [x] Manually test symbolservice (in case of regression) --------- Co-authored-by: Keegan Carruthers-Smith <keegan.csmith@gmail.com> |
||
|---|---|---|
| .. | ||
| api | ||
| database | ||
| fetcher | ||
| gitserver | ||
| observability | ||
| parser | ||
| rockskip | ||
| squirrel | ||
| types | ||