David Veszelovszki
f23537a669
Housekeeping: Rename variables to avoid collisions with packages ( #47179 )
2023-01-31 16:28:43 +01:00
David Veszelovszki
a733d031f8
Housekeeping: Remove redundant stuff from Go code ( #47104 )
...
* Fix "Type can be omitted" warnings
* Fix "Redundant import alias" warnings
* Fix "Redundant type conversion" warnings
* Fix "Redundant parentheses" warnings
* Fix typo and case
Co-authored-by: Eric Fritz <eric@sourcegraph.com>
2023-01-30 20:39:40 +00:00
Eric Fritz
c69207f871
scip: Improve OOM conditions for LSIF migration ( #47040 )
2023-01-27 19:57:12 +00:00
Alex Ostrikov
6a3096bfbd
chore: remove some dead code found by linter. ( #46940 )
...
Test plan:
CI should pass.
2023-01-25 20:43:54 +04:00
Jean-Hadrien Chabran
bc5490c4bb
bazel: introduce build files for Go ( #46770 )
2023-01-23 14:00:01 +01:00
Eric Fritz
542e437ce9
codeintel: Fix reference moniker translation ( #46391 )
2023-01-12 13:57:50 -07:00
Eric Fritz
836b6711c5
codeintel: Fix too many definitions in LSIF translation ( #46392 )
2023-01-12 12:42:42 -06:00
Eric Fritz
caac3f3d20
codeintel: Fix LSIF -> SCIP range conversion ( #46350 )
2023-01-12 08:24:45 -06:00
Eric Fritz
04ab13c7e3
codeintel: Use project root when converting LSIF to SCIP ( #46352 )
2023-01-12 09:55:28 +00:00
Noah S-C
bfa074f6c6
codeintel: dont swallow errors in upload retry mechanism ( #46281 )
2023-01-10 14:53:49 +00:00
Cesar Jimenez
2d7912569c
[language-platform] infer name and version from scip index ( #46174 )
2023-01-06 14:57:37 +00:00
Eric Fritz
2d2c86bb8d
codeintel: Infer index name when converting LSIF to SCIP ( #46091 )
2023-01-05 11:57:02 -07:00
Noah S-C
8c996a77af
codeintel: first implementation of auto-indexing secrets ( #45580 )
2022-12-15 22:32:16 +00:00
Jean-Hadrien Chabran
e540a5a309
Clean linting errors from unparam ( #45548 )
...
* extsvc.gitlab: remove unused parameter and mock
* fixup
* Re-enable unparam
* sct: fix error handling + logs in bitbucket
* monitoring: remove unused param
* monitoring: remove unused param
* extsvc/gitlab: mute unused param (see #45336 )
* sg: mute unused param
* sg/setup: fix additional checks not being called
* sg: fix unused params
* internal/user: remove unused error
* gitlab/oauth: remove nil+unused param
* webhooks: remove unused param DB
The return callback takes a DB, not the outer function.
* codeintel/autoindexing: mute unused parameter
* oobmigration: remove unused error
* database/event_logs: add missing error handling
* executors: remove unused context
* executors: remove unused err
* gitserver: remove unused param ShardId
* executors: remove another unused err
* fixup
* database/user_credentials: remove unused error
* codeintel/resolvers: remove unused ctx
* codeintel/uploads: removed unused param repositoryName
* codeintel/uploads: remove unused param repo
* fixup
* (sus) codeintel/uploads remove unused param default branch
* codenav/observability: add nolint pragma
* gitserver: remove unused return value from internal func
* add explanation to nolint
* codenav: add nolint pragma
* gitlab: remove unused context
* internal/repos: remove unused context
* cliutil: remove unused parameter
* cliutil: remove unused params/errors
* cliutil: drop another unused parameter
* repos/gitlab: remove unused parameter db
* sg/feedback: remove unused ctx
* migration: remove unused ctx parameter
* fixup cliutil ctx
* sg/src: remove unused out parameter
* codeintel/autoindexing: remove unused trace param
* rockskip: remove always nil return value
* insights: remove unused parameters/nil errs
* dotcom: remove unused logger param
* batches/httpapi: add nolint pragma for semantics
* extsvc: removed unused ctx + fix struct
* graphqlbackend: remove unused db parameter
* insights: remove unused logger
* executor: drop always nil err return val
* batches: remove always nil error
* oauth: remove unused db parameter
* batches: remove always nil error
* batches: remove always nil error
* insights: remove unused feature flags store
* insights(sus): remove unused parameter alert
* dotcom: remove unused logger
* dotcom: remove unused logger param
* insights: remove unused featureflagstore
* graphqlbackend/batches: removed unused ctx
* gitserver: simplify expression
* codeintel: remove always nil error
* batches: removed always nil error
* codeintel/lsif: remove another nil error
2022-12-13 11:18:25 +01:00
Cesar Jimenez
0f90de027d
[language-platform] adding route to check for SCIP availability ( #45269 )
2022-12-08 11:25:22 -07:00
Eric Fritz
e872ed6410
codeintel: Write SCIP data in uploads service ( #45104 )
2022-12-06 15:32:54 -06:00
Thorsten Ball
49c5aee840
Disable flaky TestConvertLSIF ( #45252 )
...
Disable flkay TestConvertLSIF
2022-12-06 12:18:17 +00:00
Eric Fritz
52fefe5292
codeintel: Add layer to translate raw/processed LSIF to SCIP ( #45126 )
2022-12-05 18:32:30 -06:00
Cesar Jimenez
f7970690c1
[language-platform] Code intelligence badge updates ( #45015 )
2022-12-02 13:28:42 -07:00
Eric Fritz
0a110a25c5
chore: Mirror Manager field in oobmigration package ( #44978 )
2022-11-30 18:01:09 -07:00
Eric Fritz
cdba72ae4d
codeintel: Add manager to monikers/package information ( #44958 )
2022-11-30 14:26:58 -06:00
Keegan Carruthers-Smith
27569d1fc7
all: run gofmt -s -w from 1.19 ( #41629 )
...
gofmt in go1.19 does a lot of reformating of godoc strings, mostly to
make them more consistent around lists.
Test Plan: CI
2022-09-13 07:44:06 +00:00
Noah S-C
30275c288b
codeintel: add dashboard for precide-code-intel-worker total in-progress upload size ( #39690 )
2022-08-11 21:43:14 +01:00
Noah S-C
abbe5e2cb4
codeintel: use io.SectionReader for codeintel uploading ( #40198 )
...
* codeintel: use io.SectionReader for codeintel uploading
* Update lib/codeintel/upload/upload.go
2022-08-10 13:33:31 +00:00
Cesar Jimenez
af80d54072
Moving transport layer functionality to the service layer ( #39516 )
2022-08-02 14:19:01 -04:00
Ólafur Páll Geirsson
2e5a366f52
Use api.RepoName and reposource.PackageName type aliases ( #38730 )
...
* Use `api.RepoName` and `reposource.PackageName` type aliases
Previously, we used strings for both types, which caused a regression
that got fixed in https://github.com/sourcegraph/sourcegraph/pull/38722 .
This commit introduces type aliases to avoid regressions like that.
While implementing the refactoring I also found a bug in Python
packages, that's fixed by this commit.
* Revert functional difference that caused tests to fail
The versioned package syntax should include the version, but the golden
tests assume the version is not included and I want to minimize the
blast radius from the refactoring.
2022-07-14 05:47:30 +00:00
Robert Lin
95c6946b9d
lib/log: migrate to github.com/sourcegraph/log ( #36834 )
...
This change migrates lib/log to https://github.com/sourcegraph/log in the hopes of easing adoption for other services.
2022-06-08 15:02:38 -07:00
Jean-Hadrien Chabran
3ea3c84343
Update services to use the sentry sink ( #36569 )
...
This patches all services that were using the HTTP middleware to capture sentry errors to now use the sentry sink.
2022-06-08 11:17:13 -07:00
Robert Lin
b2779c2221
lib: remove all usages of log15 ( #36259 )
2022-05-30 17:53:05 -07:00
Ólafur Páll Geirsson
9dcdfb95d9
Remove unused LSIF Typed code ( #35791 )
...
* Add diff for a TypeScript file to trigger CI job
* Rename job
* Delete unnecessary TypeScript file after validating CI job
* Remove unused "LSIF Typed" code
This code got moved to a separate repo github.com/sourcegraph/scip.
2022-05-25 11:23:13 +00:00
Varun Gandhi
0facf872c1
Update docs and comments to refer to scip-typescript ( #34097 )
...
codeintel: Update docs + code for scip-typescript.
Co-authored-by: Ólafur Páll Geirsson <olafurpg@gmail.com>
2022-05-24 15:38:04 +00:00
Ólafur Páll Geirsson
862f0e87d8
Start using scip-typescript for auto-indexing ( #35786 )
...
* Start using scip-typescript for auto-indexing
Previously, we used lsif-typescript for auto-indexing.
* Port scip-typescript CI upload job
* Add diff for a TypeScript file to trigger CI job
* Rename job
* Delete unnecessary TypeScript file after validating CI job
2022-05-23 16:13:25 +02:00
Eric Fritz
804051949f
chore: Do not blow up processing unrecognized edges ( #35808 )
2022-05-20 09:49:22 -07:00
Ólafur Páll Geirsson
2502cc9a48
Rename lsif-java into scip-java ( #35384 )
2022-05-18 16:45:10 +02:00
Eric Fritz
8c35e67f0e
api docs: bye ( #34798 )
2022-05-18 01:03:03 +00:00
Cesar Jimenez
07192cb583
codeintel: removing bloom filters ( #35203 )
...
remove bloom filter
Co-authored-by: Eric Fritz <eric@eric-fritz.com>
2022-05-13 11:38:40 -04:00
Keegan Carruthers-Smith
11a534cc78
lib: use any instead of interface{} ( #35121 )
...
Now that lib is on go1.18 we can use the type alias "any" instead of "interface{}".
Test Plan: cd lib && go test ./...
2022-05-09 14:55:38 +00:00
Keegan Carruthers-Smith
6578e91a3f
lib/codeintel: fix newline warning in go1.18 ( #34902 )
...
go1.18 has new warnings for Println usages which trigger go test to
fail:
codeintel/tools/lsif-repl/main.go:63:5: fmt.Println arg list ends with redundant newline
codeintel/tools/lsif-repl/main.go:145:4: fmt.Println arg list ends with redundant newline
I kept the same output, but made the newline explicit to avoid the
failure.
Test Plan: go test with go1.18 locally
2022-05-04 14:53:06 +00:00
Eric Fritz
f0b67a842f
RFC 624: (M3) Replace Go code ( #34864 )
2022-05-04 09:16:16 -05:00
Varun Gandhi
9a0013b8ae
codeintel: Update lsif-typescript flag. ( #33812 )
...
lsif-node used --inferTSConfig but lsif-typescript started
using a different spelling for consistency.
2022-04-12 17:02:08 -04:00
Eric Fritz
5571c12857
codeintel: Add auth support for GitLab ( #33254 )
2022-04-04 08:34:41 -05:00
Chris Wendt
c43da260d8
lsif utils: Switch from kingpin to flag ( #33198 )
2022-03-29 21:02:09 -07:00
Noah S-C
b1cce06276
codeintel: expose code intel info for GitTree ( #32167 )
...
Co-authored-by: Eric Fritz <eric@eric-fritz.com>
2022-03-25 13:37:13 +00:00
Ólafur Páll Geirsson
3de7655d5d
LSIF Typed: handle symbols with duplicate definitions ( #32690 )
...
* LSIF Typed: handle symbols with duplicate definitions
Fixes https://github.com/sourcegraph/lsif-typescript/issues/42
* Permit duplicate definitions with conflicting symbols
This feature is needed to reproduce real-world behavior
* Emit textDocument/references edge for definition ranges
Previously, we only added textDocument/definition edges to the
definition site meaning that "find references" did not show multiple
results for cases where the same symbol had multiple definitions.
2022-03-16 18:23:34 +00:00
Ólafur Páll Geirsson
57d3f1ba82
Start using lsif-typescript for JS/TS indexing ( #31998 )
...
* Use lsif-typescript instead of lsif-node for JS/TS indexing
This commit migrates from lsif-node to the new lsif-typescript indexer
that we have been working on for the past months. It's difficult to do
this migration incrementally so this PR touches on several different
components:
- the CI config for JS/TS indexing
- auto-inference for auto-indexing
- several bugfixes in LSIF Typed to enable cross-repo navigation
* Revert changes for Node logic
* Undo unwanted changes to yarn.lock
* Address review feedback
2022-03-15 14:57:35 +01:00
Varun Gandhi
73e054d477
Spell npm consistently. ( #32575 )
...
- Spelled as Npm or NPM depending on local case convention.
For local variables and in types, Npm should be preferred.
For fully uppercase spellings, NPM should be used.
- Default to spelling it as npm otherwise.
This matches the convention in the npm/cli code and the
recommendation in the npm/cli README.
2022-03-14 12:38:09 -07:00
Eric Fritz
5b7b17c7f2
codeintel: Add indexer version to upload records ( #32402 )
2022-03-14 08:51:13 -05:00
Thorsten Ball
8d3e231322
golangci-lint: enable unparam linter ( #31856 )
...
Team work makes the linter dream work.
Co-authored-by: Varun Gandhi <varun.gandhi@sourcegraph.com>
2022-02-28 15:31:44 +01:00
TJ DeVries
e2c2857120
lsif typed syntax highlighter v0.1 ( #30016 )
...
* (syntax-highlighter): tree-sitter,lsif-typed
* lsif_typed -> lsiftyped
* doc updates
* update docker images to match .tool-versions
* fixup: Remove submodules when running backcompat tests
2022-02-23 11:44:17 -05:00
Ólafur Páll Geirsson
d3799e2b38
LSIF Typed: miscellaneous code cleanups ( #31548 )
2022-02-21 13:36:49 +01:00
