Currently, all backend integration tests transitively depend on the client bundle. This results in rebuilds of the closure, and a (likely) cache miss on the test, when modifying any client-side files.
Given that the client bundle isnt needed for these tests, we can create targets that don't include the client bundle in its transitive closure, which should in theory improve the cache hit for backend integration tests by not having client side changes invalidate it. This would also be beneficial in local env, to keep frontend rebuilds down
To do this, we still need to create a `web.manifest.json` file due to some unfortunate requirement on that file existing as part of initializing the sourcegraph instance. For this I just create an empty json file, `select` this instead of the client bundle target in client/web/dist/BUILD.bazel based on a `//:integration_testing_enabled` config setting, and creating a `go_binary`-wrapping bazel rule + macro that automatically applies a transition to set this to true `go_binary_nobundle`, and using that rule for the specific `//cmd/{server,frontend}:{server,frontend}_nobundle` binary rules (along with the relevant `oci_{image,tarball}` etc rules to consume it).
## Test plan
- Integration tests in CI still work
- `bazel cquery 'kind("js_library", deps(//cmd/frontend:image_nobundle))'`, `bazel cquery 'kind("js_library", deps(//cmd/server:image_nobundle))'`, ``bazel cquery 'kind("js_library", deps(//testing:backend_integration_test))'` etc all return empty set
- Release test with marker in web bundle to ensure released images contain the web bundle via `sg release run test --version 5.4.2` (commenting out other tests for brevity)
* Add "welcome to Cody Pro" notification
* Trigger the notification in accept invitations
* Trigger the notification in signups
* Redirect to the correct page after accepting an invite
* Unrelated: Fix header style
This reverts commit e45c2ed.
We've decided to revert this behavior after receiving negative feedback from
several customers. Instead, we'll work to improve indexing speed and
reliability to minimize drift between search results and the file view.
This adds a link to the repository's code-graph page to the repo
navigation.
Additional changes:
- added a flag to each menu item that specifies whether
or not show the entry for non-admin users (defaults to `false`)
- updated vite's proxy configuration to properly load React repo pages
from the server
This adds a copy button to the file path in the file view, reduces spacing between path elements, and removes spaces from the the copied text for the file path.
This updates the history panel entries to allowing closing the diff and
commit view by clicking the same link again (i.e. the commit subject or
the 'view at commit' button).
This simply runs `pnpm format` and the LSPs formatter to format .svelte
files that have been recently added.
(we do not run the formatter for .svelte files in CI)
This makes each dir entry in the file popover header a link, and allows wrapping so the full path is always visible. Uses the same wrapping logic as the file header so the slashes work right. Additionally, it linkifies the commit message to point to the same page as the OID link
The repo popover has deployed to S2, but it's not visible to anyone who is not a site admin because one of the GraphQL fields used is restricted to only site admins.
This updates the query to use a non-restricted field, and also fixes the code host capitalization while I'm at it.
This re-applies #61989 after it was reverted. In addition to reapplying the change:
- It reverts the changes to Popover.svelte that removed the border.
- We only start loading data on hover, not on mount
- Various fixes in text overflow conditions
- Removes the language from the popover data because it can be very expensive to calculate
(another reason to pre-calculate language, but that's for another day)
- Moves the data loading out of the page loader. Exports the data loading function from
the component so data loading is still orchestrated by the caller. (I know this will be controversial, reasoning inline)
- Adds a delay to the popover so it doesn't get in the way as your mouse moves over the page.
- Uses the display name instead of the author name
- Linkifies the commit message
* Add config item, get it to the front end
* Use config on the front end
* Send team=1 if the team button is clicked
* Unrelated: Event logging cleanup
update: Remove A/B testing on web signup and keep on IDE signup
Co-authored-by: gitstart-sourcegraph <gitstart-sourcegraph@users.noreply.github.com>
Co-authored-by: GitStart-SourceGraph <89894075+gitstart-sourcegraph@users.noreply.github.com>
* Remove "open in new" icon
* Make "Add seats" button of the "success" type
* Add title
* Left-align "Send" button
* Remove unneeded filter
* Convert table to grid
* Fix copy
* Center align action buttons
* Update button type
* Fix copy
* Add red outline to textbox if erroneous
* Error replaces help text
* Use text-uppercase in ADMIN and INVITED labels
* Add Cody Pro REST API client library
* Expose REST API methods for Subscriptions
* Address PR feedback
* Address even more, great PR feedback
* Add unit tests
* Run 'sg lint', 'bazel run //:configure'
* Fix error from bad merge
* Lint
While looking into #62713 I stumbled upon two z-index issues. This
commit removes a bunch of z-index settings to simplifying layering.
- Instead of setting a z-index on the header to make the sidebar
navigation work, we can "portal" the sidebar to the end of the
document.
- Likewise the repo search input is portalled to ensure that it renders
above all other content.
* First run on file tree visual update
* Fix spacings and colors for the file tree items
* Fix spacing for nested levels
* Add "move to scope" feature to the file tree
* Fix go to the root repository and improve move to scope transition
* Add a comment about resetting the cache before go to the root
* Move root button to the first row
* Add fixes by PR review comments
* Fix fuzzy finder state
* Fix ts problems
* Fix width layout problem for deep nested items
