Commit Graph

11 Commits

Author SHA1 Message Date
William Bezuidenhout
8bb0ab54eb
release: never use build number in image family (#63157)
the executor image and docker mirror image should now follow the
following naming convention:

Image family:
`sourcegraph-executors-[nightly|internal|'']-<MAJOR>-<MINOR>`
Image name:
`sourcegraph-executor-[nightly|internal|'']-<MAJOR>-<MINOR>-<BUILD_NUMBER>`

example:
Image family: `sourcegraph-executors-5-4`
Image name: `sourcegraph-executor-5-4-277666`

## What happens during releases and _not_ releases?
#### Nightly
**`nightly` suffix**
Image family: `sourcegraph-executors-nightly-<MAJOR>-<MINOR>`
Image name:
`sourcegraph-executor-nightly-<MAJOR>-<MINOR>-<BUILD_NUMBER>`
#### Internal
**`internal` suffix**
Image family: `sourcegraph-executors-internal-<MAJOR>-<MINOR>`
Image name:
`sourcegraph-executor-internal-<MAJOR>-<MINOR>-<BUILD_NUMBER>`
#### Public / Promote to public

** No suffix **

Image family: `sourcegraph-executors-<MAJOR>-<MINOR>`
Image name: `sourcegraph-executor-<MAJOR>-<MINOR>-<BUILD_NUMBER>`

>  [!IMPORTANT]
> Should we keep the imagine name stable at
`sourcegraph-executor-<MAJOR>-<MINOR>-<BUILD_NUMBER>`
> and only change the family name? 
>
> **Why?**
>
> The Image family dictates the collection of images and that changes
each major minor and or release phase so there is really no use in
changing the image name too, except at a glance you can see from the
name what image family it belongs to?
## Test plan

<!-- All pull requests REQUIRE a test plan:
https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles
-->


## Changelog

<!--
1. Ensure your pull request title is formatted as: $type($domain): $what
2. Add bullet list items for each additional detail you want to cover
(see example below)
3. You can edit this after the pull request was merged, as long as
release shipping it hasn't been promoted to the public.
4. For more information, please see this how-to
https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c?

Audience: TS/CSE > Customers > Teammates (in that order).

Cheat sheet: $type = chore|fix|feat $domain:
source|search|ci|release|plg|cody|local|...
-->

<!--
Example:

Title: fix(search): parse quotes with the appropriate context
Changelog section:

## Changelog

- When a quote is used with regexp pattern type, then ...
- Refactored underlying code.
-->
2024-06-07 17:23:24 +02:00
Bolaji Olajide
894a951ad7
release(executors): update ami naming (#62579)
* update naming

* update docker mirror image family name
2024-05-14 03:56:27 -05:00
Jean-Hadrien Chabran
226e698d75
bzl: do not fail if workdir exists already (#60708)
bzl: fix mkdir
2024-03-15 12:57:43 +00:00
William Bezuidenhout
ad97b8b4ea
Reapply "ci: use aspect workflow agents (#60317)" (#60856)" (#60860)
This reverts commit 5dee69a56a.
2024-03-06 11:37:49 +02:00
William Bezuidenhout
5dee69a56a
Revert "ci: use aspect workflow agents (#60317)" (#60856)
This reverts commit 67b2c665f1.
2024-03-05 11:13:05 +00:00
William Bezuidenhout
67b2c665f1
ci: use aspect workflow agents (#60317)
* initial change to use aspect-default and remove ifs

* use rosetta bazelrc in bazel ci scripts

* use /tmp/aspect-generated.bazelrc path everywhere

change gcp project depending on queue

* restore aspect buildkite plugin
2024-03-05 12:07:47 +02:00
Noah S-C
7302f01227
executors: fix path to aws_regions.json in ami.push targets (#60612)
Bazel ami.push targets were missing the file and pointing at wrong location

## Test plan

Tested manually on buildkite agent by @jhchabran 

![image](https://github.com/sourcegraph/sourcegraph/assets/18282288/6a269f0e-9d40-45b3-9019-06cc67578953)
2024-02-19 15:42:58 +00:00
Noah S-C
4d76a70fa2
scripts: dont run subshell in for loop (#60611)
For same reason as https://github.com/sourcegraph/sourcegraph/pull/60610, cleaning up the remaining scripts

## Test plan

https://stackoverflow.com/questions/44014857/function-invocation-in-for-loop-does-not-fail-even-with-set-e
2024-02-19 14:48:33 +00:00
Jean-Hadrien Chabran
06542fc530
Port executors building/pushing scripts to use Bazel (#58892)
---------

Co-authored-by: William Bezuidenhout <william.bezuidenhout@sourcegraph.com>
2023-12-20 18:33:49 +00:00
Erik Seliger
6b5a9e953c
Fix main build due to broken paths in scripts (#55703)
Those steps don't run on not-main so missed those when moving executor
from enterprise/cmd to cmd.

## Test plan

main-dry-run.
2023-08-10 02:49:48 +02:00
Erik Seliger
4608be4136
Move executor to cmd/executor (#55700)
This is a mechanical move to get the executor out of the enterprise/cmd
directory. Eventually, this directory should disappear, this is another
step towards that.

This does not change anything about how it's licensed.

## Test plan

CI is still passing, local executor starts up.
2023-08-10 02:06:12 +02:00