Commit Graph

489 Commits

Author SHA1 Message Date
Jean-Hadrien Chabran
7e7e7c08a1
Revert "chore(ci): post instructions for PR sections in a comment" (#64187)
Reverts sourcegraph/sourcegraph#64176

Test-plan: CI
2024-07-31 13:10:06 +01:00
Jean-Hadrien Chabran
76210386a6
chore(ci): post instructions for PR sections in a comment (#64176)
Follow-up to https://github.com/sourcegraph/devx-support/issues/1130 

Moving the doc links to a comment is merely a few lines of GitHub
Script, so it's worth doing it for better merge commit messages.

## Test plan

This PR itself was the test, as you can see below the comments that
resulted from this new GH workflow. Btw, the second one is the one
you'll see in the code here. I went for a oneliner to avoid cluttering
the UI.
2024-07-31 09:37:39 +00:00
Michael Lin
4a04287e53
ci: add cloud controller gql compat test (#64092)
closes CLO-527


[context](https://sourcegraph.slack.com/archives/CHXHX7XAS/p1721835847010889)

cloud uses a lot of the GraphQL API to pre-configure instances on
customer behave, and it's very sensitive to breaking changes to the
schema upstream.

currently, we have a [cronjob github
actions](https://github.com/sourcegraph/controller/actions/workflows/srcgql-compat.yaml)
that periodically check the schema compatibility every day.

such approach works but we're always playing catch up and will have to
result in extra work on the product team to re-work the PR. it is much
better to catch this in CI time within the monorepo.

This PR added a new github actions to the monorepo that will run on any
`*.graphql` changes. Then it will remotely trigger the cronjob github
action in sourcegraph/controller to run and poll the result. See test
plan for demo.

## FAQ

### Why not run the test in buildkite or directly in this repo using
github actions?

- sourcegraph/controller is a huge repo forhistorical reason (> 2G) and
cloning it is very expensive
- the repo contains sensitive information, and we don't want to make it
possible to expose it accidentally.

### How does authentication work?

We use a [GitHub
App](https://github.com/organizations/sourcegraph/settings/apps/cloud-srcgql-compat-test-invoker)
with extremely limited permissions. It only permits the workflow to
trigger/read the workflow without any access to the source code itself.

Also, GitHub App installation access token has a life span of 1h, much
better than PAT.

![CleanShot 2024-07-25 at 21 58
44](https://github.com/user-attachments/assets/ef29a95d-5465-4e19-ab81-1dd22d14ebd7)

## Test plan

it triggered the job and it worked:

good: https://github.com/sourcegraph/sourcegraph/pull/64094
bad: https://github.com/sourcegraph/sourcegraph/pull/64095
2024-07-30 10:06:49 -07:00
William Bezuidenhout
07e59761d2
pr-auditor: use pr-auditor from devx-service (#63847)
Updates PR-auditor to use the PR-auditor from the devx-service

## Test plan
Once merged, this
[PR](https://github.com/sourcegraph/sourcegraph/pull/63846) should fail
2024-07-16 11:10:36 +02:00
Matthew Manela
d839e44d40
feat(codeintel): Add scip-ctags support for Magik (#63504)
Add symbol browsing support for the Magik language
2024-07-08 09:24:36 -04:00
Bolaji Olajide
8b63626f74
fix(actions): update pinned SHA for pnpm/action-setup action (#63632)
Update the pinned SHA for `pnpm/action-setup`

<!-- PR description tips:
https://www.notion.so/sourcegraph/Write-a-good-pull-request-description-610a7fd3e613496eb76f450db5a49b6e
-->

## Test plan

<!-- REQUIRED; info at
https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles
-->
License checker for this PR passing.

## Changelog

<!-- OPTIONAL; info at
https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c
-->
2024-07-04 01:49:10 -05:00
Noah S-C
8412e6b45d
chore(ci): remove buildchecker sunday summary posts (#63289)
https://linear.app/sourcegraph/issue/DINF-36/kill-automated-ci-report

## Test plan

Still compiles, meaning at best everything unused is gone, at worst
we've got unused stuff left over but nothing necessary still remaining


## Changelog
2024-06-17 13:05:39 +00:00
Noah S-C
79fce8c73e
feat(ci): add GHA to report when Bazel test ownership drops below 70% threshold (#62985)
This PR adds a non-blocking GHA check to report when a branch's Bazel test ownership drops below 70%. See example messaging below to see how it looks like: https://github.com/sourcegraph/sourcegraph/pull/62985#issuecomment-2139439084. The message will be updated if the threshold is reached/breached whenever the branch changes.

## Test plan

Extensive iteration in this PR, see below message https://github.com/sourcegraph/sourcegraph/pull/62985#issuecomment-2139439084


## Changelog
2024-05-31 14:46:01 +01:00
Anish Lakhwara
eb81e680e0
chores(ci): remove AMI automation (#62975) 2024-05-30 12:30:05 -07:00
Jean-Hadrien Chabran
d27c590c83
chore(gha): link to how-to when license check fail (#62857) 2024-05-22 14:44:10 +00:00
Michael Bahr
e85028b8bd
fix: update links for dev docs (#62758)
* fix: license checker info is in docs-legacy

* fix: update remaining dev links
2024-05-17 13:47:34 +02:00
Varun Gandhi
cb03009ca0
chore: Stop uploading indexes to k8s.sgdev.org (#62595)
Co-authored-by: Anton Sviridov <velvetbaldmime@protonmail.com>
2024-05-15 09:55:36 +01:00
Anton Sviridov
ca5618443b
Remove SCIP upload to dogfood host (#62625) 2024-05-13 12:42:16 +01:00
Michael Bahr
a71189be0b
feat(gha): introduce new workflow to restrict image sizes for docs (#62268) 2024-05-13 09:11:37 +00:00
Anton Sviridov
d24a14f34d
chore: Use SRC_ACCESS_TOKEN for uploading indexes (#62593) 2024-05-10 22:50:45 +08:00
James McNamara
4cc7fe3013
chore(ci): Remove dead boards (#62544)
removed dead boards
2024-05-08 14:45:39 +00:00
Anish Lakhwara
2234704654
Build AMIs on release (#62312)
ci(amis): publish on release
2024-05-01 17:13:56 +00:00
Robert Lin
1ff9bc70eb
sg-binary-release: stamp with GitHub release name (#62176)
We have nice release names in https://github.com/sourcegraph/sg/releases, but it's not actually programmatically available - this causes a discrepancy between the `sg` version one might pull, and the version of `sg` that is known in-code, and means that we can't do something like #62134.

This change adds a `ReleaseName` variable to be stamped at build/release time, and updates a few references to `BuildCommit` where I think it might be more prudent to report `ReleaseName` instead, and also fixes some yellow squiggles in my IDE on files I visited (sorry) and some noisy `-v` output (sorry again)

## Test plan

```
$ go build -ldflags "-s -w -X main.BuildCommit=$(git rev-list -1 HEAD .) -X main.ReleaseName=hello-world" -o ./sg ./dev/sg                       
$ ./sg version
hello-world
$ ./sg -v version
Version: hello-world
Build commit: b23db0be5e
```
2024-04-25 08:10:55 -07:00
Robert Lin
7e2f77fdef
workflows: remove sg-msp variant from sg publish (#62161)
We no longer require a build variant, and MSP is now included by default since https://github.com/sourcegraph/sourcegraph/pull/59087.

Remaining reference to the variant was removed in https://github.com/sourcegraph/managed-services/pull/1288.
2024-04-24 15:29:14 -07:00
Will Dollman
370ea21eb3
Automatically check for updates to packaged dependencies (#61933)
* Add update config for universal-ctags

* Add upstream monitoring for additional packages

* Add context to disabled release checking

* Fix s3proxy upstream

* Add new wolfictl action

* Try running wolfictl update --dry-run

* Add repo

* Add env

* Use checkout

* Remove checkout as it confuses wolfictl

* Trick wolfictl

* Fix env

* path

* Tweaks for wolfictl

* Remove checkout again

* Add base branch for testing

* Remove branch now that changes are on main

* Tweak labels

* Add some extra flags

* Fix flags?

* Fix quotes

* Build and use forked wolfictl

* Fix path for checkout

* Relative checkout path

* use path under workspace

* Move binary rather than directory

* Don't pass --dry-run on main

* Remove dry-run mode

* Use patched branch

* Add yam.yaml

* Tweak comments

* Remove syntect-server

* Revert s3proxy changes

* Bump epoch to appease CI

* Revert "Bump epoch to appease CI"

This reverts commit 4e3925ccb6.

* Remove yam.yaml (added on different branch)

* Add git author information

* Give repo write permissions

* Check for all packages

* Enable cron and add personal TODO

* Reformat wolfictl command

* Remove on: push

* Add review suggestions

* Tweak workflow dispatch?

* add push ack

* Remove debugging

* Remove on: push
2024-04-18 09:53:39 +00:00
Noah S-C
3efa3c6ebc
sg: brew link postgresql@12 (#61829)
## Test plan

CI and tested commands manually
2024-04-12 14:41:47 +01:00
Anish Lakhwara
b03664e7ab
Trigger AMI Pipeline on release (#61484)
* ci: init trigger to pipeline on release

* ci: add release number as env var

* ci: testing action now that the env var is in place

* ci: more testing

* ci: add name

* ci: tested!

* ci(AMIs): pin GHA trigger BK

* ci: add workflow_dispatch

* ci: change branch to main
2024-04-09 12:12:52 -07:00
Noah S-C
1fcc1f0e32
nix: build pg-utils with nix & upload to GCS (#61658)
Lets get rid of PG_UTILS_PATH! :allthethings: 🎉 

## Test plan

CI and a _lot_ of  `nix build .#pg-utils && ldd ./result/bin/pg_dump`
also tested e2e with the following diff: 61e0eb0d55
2024-04-09 11:54:17 +01:00
Jean-Hadrien Chabran
8f9ed34868
chore/gha: remove docsite previewing (#61289) 2024-03-20 10:05:04 +00:00
Jean-Hadrien Chabran
f7efbcb4c2
feat/ci: ship a static variant of sg linux/amd64 on (#61191)
feat/ci: ship a static variant of sg linux/amd64
2024-03-15 11:59:30 +00:00
Vincent
1a9954fc59
Pin third-party actions (#61037)
* pin third-party actions
2024-03-12 16:32:27 +00:00
William Bezuidenhout
3b0c388a70
Github Acionts: update workflows to use go 1.22 (#60993)
update workflows to use go 1.22
2024-03-11 13:22:26 +02:00
Noah S-C
cb7034680d
bump to Go 1.22.1 (#60902)
🚀 💎 🙌 🚙 

## Test plan

CI
2024-03-06 17:38:43 -07:00
Bolaji Olajide
b6d929ab64
remove release protector (#60755) 2024-02-26 14:59:12 -06:00
Christoph Hegemann
6ac8c61294
More updates for deprecated src-cli command (#59633)
removes more deprecated uses of `src lsif`
2024-01-18 09:52:42 +00:00
Noah S-C
cf2e4bbb32
chore: fix universal-ctags darwin GHA workflow (#59477)
Fixed bad copy-paste job 🤡 

## Test plan

Manually invoked workflow https://github.com/sourcegraph/sourcegraph/actions/runs/7476990901/job/20348648403
2024-01-10 15:42:36 +00:00
Noah S-C
1cc6243434
chore: update universal-ctags GHA workflow (#59476)
Bringing in-line with versions from https://github.com/sourcegraph/p4-fusion/blob/master/.github/workflows/nix-build-and-upload.yaml

## Test plan

With `act` locally
2024-01-10 14:24:31 +00:00
Erik Seliger
5ae8cf2679
Stop tagging @mrnugget (#59184) 2023-12-21 22:04:15 +00:00
William Bezuidenhout
9d821b78b6
sentry action reporter: set the repo name in the event message (#59161)
* sentry report action: set repo name in event msg

* fail pr-auditor on purpose

* Revert "fail pr-auditor on purpose"
2023-12-21 12:17:58 +00:00
Erik Seliger
f9ac351dc3
Remove App from codebase (#59115)
Cody no longer needs it and it is obsolete now!

Since App added a non-insignificant amount of new concepts and alternative code paths, I decided to take some time and remove it from out codebase.
This PR removes ~21k lines of code. If we ever want parts of single binary (app), the redis kv alternatives, or the release pipeline for a native mac app back, we can look back at this PR and revert parts of it, but maintaining 21k lines of code and many code paths for which I had to delete a surprisingly small amount of tests justifies this move for me very well.

Technically, to some extent SG App and Cody App both still existed in the codebase, but we don't distribute either of them anymore, so IMO we shouldn't keep this weight in our code.

So.. here we go.

This should not affect any of the existing deployments, we only remove functionality that was special-cased for app.
2023-12-21 01:07:05 +01:00
William Bezuidenhout
a3143120c4
actions: create reusable workflow for sentry reports (#59098)
* actions: create reusable workflow for sentry reports
2023-12-20 17:05:03 +02:00
William Bezuidenhout
836271fddf
github-actions: report run failures to sentry (#59060)
* github-actions: report run failures to sentry

* report job name as well

* make buildchecker action consistent
2023-12-18 16:06:50 +00:00
William Bezuidenhout
d4660297f3
buildchecker: send an event to sentry if the action has failed (#59059)
* buildchecker: add step to report failures to sentry

* use dsn for sentry in action

* remove debug exit 1
2023-12-18 15:04:19 +02:00
William Bezuidenhout
c4e28460b0
license checker: update reviewers for automated update license pr (#59053) 2023-12-18 10:56:43 +02:00
William Bezuidenhout
cc03635fdd
pr-auditor: use token secret (#58933) 2023-12-12 16:35:32 +00:00
Noah S-C
e821ef3c7f
bump go version in buildchecker (#58775) 2023-12-05 13:36:45 +00:00
Michael Lin
172d70097e
ci: bump go to 1.21 in gitub actions (#58642) 2023-11-28 21:33:58 -08:00
Camden Cheek
9b63655fca
Chore: remove team notification every time "batch" is mentioned (#58050) 2023-11-01 15:45:40 +00:00
Joe Chen
f145afbddd
chore: update label-notify.yml for Cody Gateway (#57968) 2023-10-30 09:32:39 +02:00
Michael Lin
c54a6a54b3
ci: fix sg msp is not release (#57955)
* ci: fix sg msp is not release

* Update sg-binary-release.yml
2023-10-27 15:48:24 -07:00
William Bezuidenhout
cf09ced6c5
license check: update versions used by workflow (#57943)
* update versions used by license check workflow

* update ruby version

* update pnpm version
2023-10-27 11:46:06 +00:00
Michael Lin
1b1bc4dadf
ci: release sg msp build (#57935) 2023-10-26 18:23:27 -07:00
Quinn Slack
b1c79d7c2e
bump pnpm version in scip-typescript workflow (#57921) 2023-10-26 05:06:42 -07:00
s.shivasurya
4a296825ad
Remove Secret Scan Github Action in favour of Background Secret Scan (#57678)
remove trufflehog scan in favour of background scan
2023-10-17 18:00:13 +00:00
Ólafur Páll Geirsson
a0b711d35e
JetBrains: remove plugin (#57505)
The plugin codebase has been moved to the sourcegraph/jetbrains
repository. We keep the web assets for Code Search features inside this
repository.
2023-10-17 09:03:43 +00:00