Commit Graph

10 Commits

Author SHA1 Message Date
Greg Magolan
fd50106a34
chore: upgrade to Aspect CLI 5.8.19 (#59203)
Co-authored-by: Jason Bedard <jason@aspect.dev>
2024-01-02 15:13:24 +01:00
Jean-Hadrien Chabran
078b2eb3b4
bzl: update to aspect-cli 5.8.16 (#58843) 2023-12-08 10:44:04 +00:00
Greg Magolan
98563e5830
chore: upgrade to Aspect CLI 5.8.5 (#57961)
Co-authored-by: William Bezuidenhout <william.bezuidenhout@sourcegraph.com>
2023-10-30 17:01:58 +02:00
Greg Magolan
12506b0610
build: update to Aspect CLI 5.5.4 (#54468)
Suppresses the incorrect syntax error warning span when running `bazel
configure`

https://github.com/aspect-build/aspect-cli/releases/tag/5.5.4
2023-06-29 22:44:05 -07:00
Greg Magolan
09d898704a
build: update to Aspect CLI 5.5.2 (#53692)
Required adding a few import ignore directives in
`client/web/BUILD.bazel`. @jbedard is working on a fix for those. Has to
do with tsconfig paths. Fix will land in a future release.

## Test plan

5.4.11 output:

```
$ bazel configure
Updating BUILD files for protobuf, go, javascript
WARN[0000] Failed to load base tsconfig file @sourcegraph/tsconfig: open /Users/greg/aspect/sourcegraph/sourcegraph/@sourcegraph/tsconfig: no such file or directory 
client/app-shell/src/app-shell.tsx parse error(s):
50: Top-level await is currently not supported with the "iife" output format
Failed to parse tsconfig file client/completions-review-tool/tsconfig.json: ERR: position:298 object key must be string pos:298 : 
933 BUILD files visited
0 BUILD files updated
```

5.5.2 output has some new spam as well:

```
$ bazel configure
Updating BUILD files for protobuf, go, javascript
WARN[0000] Failed to load base tsconfig file @sourcegraph/tsconfig: open /Users/greg/aspect/sourcegraph/sourcegraph/@sourcegraph/tsconfig: no such file or directory 
Failed to parse tsconfig file client/completions-review-tool/tsconfig.json: ERR: position:298 object key must be string pos:298 : 
client/web/src/globals.d.ts:
	     17: }
         ^

client/web/src/storm/backend/route-loader.ts:
	     41:     usePreloadedQueryData: () => ReturnType<typeof useSuspenseQuery<D, V>>
                                                    ^
	     41:     usePreloadedQueryData: () => ReturnType<typeof useSuspenseQuery<D, V>>
                                                     ^

934 BUILD files visited
0 BUILD files updated
```
2023-06-22 18:33:15 +02:00
Greg Magolan
6c0654dc4f
chore: update to Aspect CLI 5.4.11 (#52533)
v5.4.11 release should resolve the `bazel build $(bazel query)` piping
issue as it includes a fix to direct CLI plugin status to stderr instead
of stdout.

## Test plan

CI
2023-05-27 08:40:03 +02:00
Valery Bugakov
043906c167
bazel: upgrade bazel-cli (#51141) 2023-04-26 02:18:05 -07:00
Greg Magolan
e4149d55dc
chore: update to Aspect CLI 5.2.1 (#48798)
Fixes regresion in 5.2.0 for detecting the workspace & finding
.bazelversion.

Test plan: CI & local testing



## Test plan

<!-- All pull requests REQUIRE a test plan:
https://docs.sourcegraph.com/dev/background-information/testing_principles
-->
2023-03-07 10:13:33 +01:00
Greg Magolan
8004a17b89
chore: update to Aspect CLI 5.2.0 (#48743)
5.2.0 CLI release requires opting into configure languages in
`.aspect/cli/config.yaml`

Test plan: CI
2023-03-06 17:37:16 +01:00
Valery Bugakov
6bf58cccca
bazel: add .bazeliskrc with Aspect-CLI (#48411)
Are there any downsides to using the Aspect CLI by default? If we want
to ask our engineers to rely on it, we should start testing it asap.
2023-03-01 01:27:14 -08:00