diff --git a/internal/search/client/client.go b/internal/search/client/client.go index 91ed6460865..3e48b03e185 100644 --- a/internal/search/client/client.go +++ b/internal/search/client/client.go @@ -247,6 +247,9 @@ func SearchTypeFromString(patternType string) (query.SearchType, error) { return query.SearchTypeCodyContext, nil case "keyword": return query.SearchTypeKeyword, nil + // NOTE: the lucky patterntype is deprecated. For now, we remap it to 'standard' to avoid breaks. + case "lucky": + return query.SearchTypeStandard, nil default: return -1, errors.Errorf("unrecognized patternType %q", patternType) } @@ -297,6 +300,9 @@ func overrideSearchType(input string, searchType query.SearchType) query.SearchT searchType = query.SearchTypeCodyContext case "keyword": searchType = query.SearchTypeKeyword + // NOTE: the lucky patterntype is deprecated. For now, we remap it to 'standard' to avoid breaks. + case "lucky": + searchType = query.SearchTypeStandard } }) return searchType diff --git a/internal/search/client/client_test.go b/internal/search/client/client_test.go index 3bf70ce5139..d27a20c2ea7 100644 --- a/internal/search/client/client_test.go +++ b/internal/search/client/client_test.go @@ -20,6 +20,7 @@ import ( func TestDetectSearchType(t *testing.T) { typeRegexp := "regexp" typeLiteral := "literal" + typeLucky := "lucky" testCases := []struct { name string version string @@ -40,6 +41,8 @@ func TestDetectSearchType(t *testing.T) { {"V2, override regex variant pattern type with single quotes", "V2", &typeLiteral, `patterntype:'regex'`, query.SearchTypeRegex}, {"V1, override literal pattern type", "V1", &typeRegexp, "patterntype:literal", query.SearchTypeLiteral}, {"V1, override literal pattern type, with case-insensitive query", "V1", &typeRegexp, "pAtTErNTypE:literal", query.SearchTypeLiteral}, + {"V1, lucky pattern type should be mapped to standard", "V1", &typeLucky, "", query.SearchTypeStandard}, + {"V1, lucky pattern type in query should be mapped to standard", "V1", nil, "patternType:lucky", query.SearchTypeStandard}, } for _, test := range testCases {