artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 17:31:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

add React key to fragments in code monitoring logs (#63479)

Browse Source 
Fixes the "missing key" React warning.


## Test plan

Ensure no console warning
This commit is contained in:
Quinn Slack 2024-06-26 02:06:54 -07:00 committed by GitHub
parent 732c7c8675
commit eacde544f3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 21 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
client/web/src/enterprise/code-monitoring/CodeMonitoringLogs.tsx
View File

@ -65,18 +65,21 @@ export const CODE_MONITOR_EVENTS = gql`
actions {
nodes {
... on MonitorWebhook {
id
__typename
events {
...MonitorActionEvents
}
}
... on MonitorEmail {
id
__typename
events {
...MonitorActionEvents
}
}
... on MonitorSlackWebhook {
id
__typename
events {
...MonitorActionEvents

4
client/web/src/enterprise/code-monitoring/components/logs/TriggerEvent.tsx
View File

@ -106,7 +106,7 @@ export const TriggerEvent: React.FunctionComponent<
/>
{triggerEvent.actions.nodes.map(action => (
<>
<React.Fragment key={action.id}>
{action.events.nodes.map(actionEvent => (
<CollapsibleDetailsWithStatus
key={actionEvent.id}
@ -125,7 +125,7 @@ export const TriggerEvent: React.FunctionComponent<
startOpen={startOpen}
/>
)}
</>
</React.Fragment>
))}
</ConnectionList>
)}

20
client/web/src/enterprise/code-monitoring/testing/util.ts
View File

@ -1,7 +1,7 @@
import type { AuthenticatedUser } from '../../../auth'
import {
type CodeMonitorFields,
EventStatus,
type CodeMonitorFields,
type ListCodeMonitors,
type MonitorTriggerEventsResult,
} from '../../../graphql-operations'
@ -53,13 +53,13 @@ export const mockCodeMonitorFields: CodeMonitorFields = {
},
}
export const mockCodeMonitor = {
export const mockCodeMonitor: { node: CodeMonitorFields } = {
node: {
__typename: 'Monitor',
id: 'foo0',
description: 'Test code monitor',
enabled: true,
owner: { id: 'test-id', namespaceName: 'test-user' },
owner: { id: 'test-id', namespaceName: 'test-user', url: '/user/test-user' },
actions: {
nodes: [
{
@ -67,7 +67,7 @@ export const mockCodeMonitor = {
id: 'test-action-0',
enabled: true,
includeResults: false,
recipients: { nodes: [{ id: 'baz-0', url: '/user/test' }] },
recipients: { nodes: [{ id: 'baz-0' }] },
},
{
__typename: 'MonitorSlackWebhook',
@ -400,6 +400,7 @@ export const mockLogs: MonitorTriggerEventsResult = {
nodes: [
{
__typename: 'MonitorEmail',
id: 'm1',
events: {
__typename: 'MonitorActionEventConnection',
nodes: [],
@ -407,6 +408,7 @@ export const mockLogs: MonitorTriggerEventsResult = {
},
{
__typename: 'MonitorSlackWebhook',
id: 'm2',
events: {
__typename: 'MonitorActionEventConnection',
nodes: [
@ -436,6 +438,7 @@ export const mockLogs: MonitorTriggerEventsResult = {
nodes: [
{
__typename: 'MonitorEmail',
id: 'm3',
events: {
__typename: 'MonitorActionEventConnection',
nodes: [],
@ -443,6 +446,7 @@ export const mockLogs: MonitorTriggerEventsResult = {
},
{
__typename: 'MonitorSlackWebhook',
id: 'm4',
events: {
__typename: 'MonitorActionEventConnection',
nodes: [
@ -472,6 +476,7 @@ export const mockLogs: MonitorTriggerEventsResult = {
nodes: [
{
__typename: 'MonitorEmail',
id: 'm5',
events: {
__typename: 'MonitorActionEventConnection',
nodes: [],
@ -479,6 +484,7 @@ export const mockLogs: MonitorTriggerEventsResult = {
},
{
__typename: 'MonitorSlackWebhook',
id: 'm6',
events: {
__typename: 'MonitorActionEventConnection',
nodes: [
@ -543,6 +549,7 @@ export const mockLogs: MonitorTriggerEventsResult = {
nodes: [
{
__typename: 'MonitorSlackWebhook',
id: 'm7',
events: {
__typename: 'MonitorActionEventConnection',
nodes: [
@ -588,6 +595,7 @@ export const mockLogs: MonitorTriggerEventsResult = {
nodes: [
{
__typename: 'MonitorEmail',
id: 'm8',
events: {
__typename: 'MonitorActionEventConnection',
nodes: [],
@ -595,6 +603,7 @@ export const mockLogs: MonitorTriggerEventsResult = {
},
{
__typename: 'MonitorSlackWebhook',
id: 'm9',
events: {
__typename: 'MonitorActionEventConnection',
nodes: [
@ -610,6 +619,7 @@ export const mockLogs: MonitorTriggerEventsResult = {
},
{
__typename: 'MonitorWebhook',
id: 'm10',
events: {
__typename: 'MonitorActionEventConnection',
nodes: [],
@ -647,6 +657,7 @@ export const mockLogs: MonitorTriggerEventsResult = {
nodes: [
{
__typename: 'MonitorEmail',
id: 'm11',
events: {
__typename: 'MonitorActionEventConnection',
nodes: [],
@ -654,6 +665,7 @@ export const mockLogs: MonitorTriggerEventsResult = {
},
{
__typename: 'MonitorSlackWebhook',
id: 'm12',
events: {
__typename: 'MonitorActionEventConnection',
nodes: [