artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 18:51:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(svelte): Properly redirect to cody marketing page (#64331)

Browse Source 
Fixes srch-851

A consequence of https://github.com/sourcegraph/sourcegraph/pull/64272
is that redirecting to the cody marketing page on dotcom didn't work.
That's because `/cody` is not provided by the server as a known page.

A simple fix would be to mark the link as external, but we'd have to
keep in mind to do this in all places (present and future).

A more "central" fix is to add this page to a hardcoded list of known
pages that are not provided by the server.


## Test plan

Manual testing
This commit is contained in:
Felix Kling 2024-08-07 15:24:02 +02:00 committed by GitHub
parent 2e0a3ee92e
commit e4e1f55026
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
client/web-sveltekit/src/lib/navigation.ts
View File

@ -4,11 +4,17 @@ import { svelteKitRoutes, type SvelteKitRoute } from './routes'
let knownRoutesRegex: RegExp | undefined
// Additional known routes that are not in the list of known routes provided by the server.
// Having a separate list is error-prone and should be avoided if possible.
const additionalKnownRoutes: string[] = [
// Cody's marketing page
'^/cody/?$',
]
function getKnownRoutesRegex(): RegExp {
if (!knownRoutesRegex) {
const knownRoutes = (browser && window.context?.svelteKit?.knownRoutes) || []
knownRoutesRegex =
knownRoutes.length === 0 ? /$^/ : new RegExp(`(${window.context?.svelteKit?.knownRoutes?.join(')|(')})`)
const knownRoutes = additionalKnownRoutes.concat((browser && window.context?.svelteKit?.knownRoutes) || [])
knownRoutesRegex = knownRoutes.length === 0 ? /$^/ : new RegExp(`${knownRoutes.join('|')}`)
}
return knownRoutesRegex
}