From e08f68eadefebb8fdfa79f370ad198af6cb976c7 Mon Sep 17 00:00:00 2001
From: Nick Snyder <nickdsnyder@gmail.com>
Date: Tue, 18 Dec 2018 13:35:56 -0800
Subject: [PATCH] remove changelog check (#1495)

---
 .github/pull_request_template.md |  3 +++
 dev/check/all.sh                 |  1 -
 dev/check/require-changelog.sh   | 41 --------------------------------
 3 files changed, 3 insertions(+), 42 deletions(-)
 create mode 100644 .github/pull_request_template.md
 delete mode 100755 dev/check/require-changelog.sh

diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
new file mode 100644
index 00000000000..b72434c0844
--- /dev/null
+++ b/.github/pull_request_template.md
@@ -0,0 +1,3 @@
+<!--
+Remember to update the changelog for user facing changes.
+-->
diff --git a/dev/check/all.sh b/dev/check/all.sh
index 7f6714eb1ca..571f9540601 100755
--- a/dev/check/all.sh
+++ b/dev/check/all.sh
@@ -15,7 +15,6 @@ go env
 ./todo-security.sh
 ./no-localhost-guard.sh
 ./bash-syntax.sh
-./require-changelog.sh
 
 # TODO(sqs): Reenable this check when about.sourcegraph.com is reliable. Most failures come from its
 # downtime, not from broken URLs.
diff --git a/dev/check/require-changelog.sh b/dev/check/require-changelog.sh
deleted file mode 100755
index 84248071649..00000000000
--- a/dev/check/require-changelog.sh
+++ /dev/null
@@ -1,41 +0,0 @@
-#!/bin/bash
-
-echo "--- require changelog"
-
-set -x
-
-if [ "$BUILDKITE_PULL_REQUEST_BASE_BRANCH" != "master" ]; then
-    set +x
-    echo "CHANGELOG.md entry not required since this isn't a pull request into master"
-    exit 0
-fi
-
-git fetch origin master
-
-changed_files=$(git diff --name-only origin/master...)
-
-# If the changed files don't match any of these regular expressions
-# then no changelog entry is required.
-if ! echo "${changed_files}" | grep -qE -e '(cmd|pkg|schema)/.*\.go$' -e '(shared|web)/.*\.(tsx?|json)$'; then
-    set +x
-    echo "CHANGELOG.md entry not required for these file changes"
-    exit 0
-fi
-
-if echo "${changed_files}" | grep -q '^CHANGELOG\.md$'; then
-    set +x
-    echo "CHANGELOG.md entry found"
-    exit 0
-fi
-
-if git log origin/master... --pretty=format:%B | grep -q NOCHANGELOG; then
-    set +x
-    echo "Found NOCHANGELOG in commit message so no CHANGELOG.md entry is required"
-    exit 0
-fi
-
-set +x
-echo "Changes that impact customers require an entry in CHANGELOG.md."
-echo "If a changelog entry is not appropriate for this change then include NOCHANGELOG in any commit message on your branch."
-echo "git commit --allow-empty -m NOCHANGELOG"
-exit 1