diff --git a/client/branded/src/global-styles/colors.scss b/client/branded/src/global-styles/colors.scss index 2c05a4a4488..f1d968ef235 100644 --- a/client/branded/src/global-styles/colors.scss +++ b/client/branded/src/global-styles/colors.scss @@ -204,7 +204,6 @@ $theme-colors: ( rgba(215, 240, 253, 0.25) 83.64% ); --modal-bg: #{rgba($gray-04, 0.5)}; - // Colors used in the search sidebar with .core-workflow-improvements-enabled --sidebar-bg: var(--color-bg-1); --sidebar-border-color: var(--border-color-2); } @@ -296,7 +295,6 @@ $theme-colors: ( --marketing-gradient: linear-gradient(90.64deg, rgba(108, 8, 223, 0.5) 3.11%, rgba(0, 165, 213, 0.5) 83.64%); --marketing-gradient-25: linear-gradient(90.64deg, rgba(108, 8, 223, 0.25) 3.11%, rgba(0, 165, 213, 0.25) 83.64%); --modal-bg: #{rgba($gray-08, 0.5)}; - // Colors used in the search sidebar with .core-workflow-improvements-enabled --sidebar-bg: var(--black); --sidebar-border-color: var(--color-bg-2); } diff --git a/client/search-ui/src/components/CommitSearchResult.tsx b/client/search-ui/src/components/CommitSearchResult.tsx index 09cd400501a..1870acf82fa 100644 --- a/client/search-ui/src/components/CommitSearchResult.tsx +++ b/client/search-ui/src/components/CommitSearchResult.tsx @@ -7,7 +7,6 @@ import SourceCommitIcon from 'mdi-react/SourceCommitIcon' import { displayRepoName } from '@sourcegraph/shared/src/components/RepoLink' import { PlatformContextProps } from '@sourcegraph/shared/src/platform/context' import { CommitMatch, getCommitMatchUrl, getRepositoryUrl } from '@sourcegraph/shared/src/search/stream' -import { useCoreWorkflowImprovementsEnabled } from '@sourcegraph/shared/src/settings/useCoreWorkflowImprovementsEnabled' // eslint-disable-next-line no-restricted-imports import { Timestamp } from '@sourcegraph/web/src/components/time/Timestamp' import { Link, Code } from '@sourcegraph/wildcard' @@ -36,15 +35,13 @@ export const CommitSearchResult: React.FunctionComponent = ({ as, index, }) => { - const [coreWorkflowImprovementsEnabled] = useCoreWorkflowImprovementsEnabled() - const renderTitle = (): JSX.Element => (
{displayRepoName(result.repository)} diff --git a/client/search-ui/src/components/FileMatchChildren.module.scss b/client/search-ui/src/components/FileMatchChildren.module.scss index 77597609e95..255d9b5ab7c 100644 --- a/client/search-ui/src/components/FileMatchChildren.module.scss +++ b/client/search-ui/src/components/FileMatchChildren.module.scss @@ -1,15 +1,10 @@ .file-match-children { background-color: var(--code-bg); - border: 1px solid var(--border-color); border-radius: var(--border-radius); padding: 0.25rem 0; position: relative; - :global(.core-workflow-improvements-enabled) & { - border: none; - } - - :global(.core-workflow-improvements-enabled) [data-collapsible='true'] & { + [data-collapsible='true'] & { border-bottom-left-radius: 0; border-bottom-right-radius: 0; } @@ -67,11 +62,7 @@ position: relative; &:not(:first-child) { - border-top: 1px solid var(--border-color-2); - - :global(.core-workflow-improvements-enabled) & { - border-top-color: var(--border-color); - } + border-top: 1px solid var(--border-color); } } } diff --git a/client/search-ui/src/components/FileMatchChildren.tsx b/client/search-ui/src/components/FileMatchChildren.tsx index 527381809f1..5ef0bb7d904 100644 --- a/client/search-ui/src/components/FileMatchChildren.tsx +++ b/client/search-ui/src/components/FileMatchChildren.tsx @@ -21,13 +21,10 @@ import { Controller as ExtensionsController } from '@sourcegraph/shared/src/exte import { HoverContext } from '@sourcegraph/shared/src/hover/HoverOverlay.types' import { ContentMatch, SymbolMatch, PathMatch, getFileMatchUrl } from '@sourcegraph/shared/src/search/stream' import { SettingsCascadeProps } from '@sourcegraph/shared/src/settings/settings' -import { useCoreWorkflowImprovementsEnabled } from '@sourcegraph/shared/src/settings/useCoreWorkflowImprovementsEnabled' -import { SymbolIcon } from '@sourcegraph/shared/src/symbols/SymbolIcon' import { SymbolTag } from '@sourcegraph/shared/src/symbols/SymbolTag' import { TelemetryProps } from '@sourcegraph/shared/src/telemetry/telemetryService' import { codeCopiedEvent } from '@sourcegraph/shared/src/tracking/event-log-creators' import { useCodeIntelViewerUpdates } from '@sourcegraph/shared/src/util/useCodeIntelViewerUpdates' -import { Link, Code } from '@sourcegraph/wildcard' import { CodeExcerpt, FetchFileParameters } from './CodeExcerpt' import { LastSyncedIcon } from './LastSyncedIcon' @@ -148,8 +145,6 @@ function navigateToFileOnMiddleMouseButtonClick(event: MouseEvent): } export const FileMatchChildren: React.FunctionComponent> = props => { - const [coreWorkflowImprovementsEnabled] = useCoreWorkflowImprovementsEnabled() - /** * If LazyFileResultSyntaxHighlighting is enabled, we fetch plaintext * line ranges _alongside_ the typical highlighted line ranges. @@ -347,14 +342,9 @@ export const FileMatchChildren: React.FunctionComponent {result.repoLastFetched && } @@ -366,23 +356,7 @@ export const FileMatchChildren: React.FunctionComponent ( - - - - {symbol.name}{' '} - {symbol.containerName && {symbol.containerName}} - - - ))} - - {((coreWorkflowImprovementsEnabled && result.type === 'symbol' && result.symbols) || []).map(symbol => ( + {((result.type === 'symbol' && result.symbols) || []).map(symbol => (
0 && (
- {grouped.map((group, index) => ( + {grouped.map(group => (
> = props => { - const [coreWorkflowImprovementsEnabled] = useCoreWorkflowImprovementsEnabled() const result = props.result const repoAtRevisionURL = getRepositoryUrl(result.repository, result.branches) const revisionDisplayName = getRevision(result.branches, result.commit) @@ -115,10 +113,10 @@ export const FileSearchResult: React.FunctionComponent { if (!isErrorLike(settings) && settings?.experimentalFeatures?.clientSearchResultRanking === BY_LINE_RANKING) { - return new LineRanking(coreWorkflowImprovementsEnabled ? 5 : 10) + return new LineRanking(5) } - return new ZoektRanking(coreWorkflowImprovementsEnabled ? 3 : 5) - }, [settings, coreWorkflowImprovementsEnabled]) + return new ZoektRanking(3) + }, [settings]) // The number of lines of context to show before and after each match. const context = useMemo(() => { @@ -200,7 +198,7 @@ export const FileSearchResult: React.FunctionComponent ), allExpanded: props.allExpanded, @@ -277,10 +275,8 @@ export const FileSearchResult: React.FunctionComponent, expandedChildren, - collapseLabel: coreWorkflowImprovementsEnabled ? 'Show less' : `Hide ${length}`, - expandLabel: coreWorkflowImprovementsEnabled - ? `Show ${length} more ${pluralize('match', length, 'matches')}` - : `${length} more`, + collapseLabel: 'Show less', + expandLabel: `Show ${length} more ${pluralize('match', length, 'matches')}`, matchCountLabel, as: props.as, } diff --git a/client/search-ui/src/components/RepoSearchResult.tsx b/client/search-ui/src/components/RepoSearchResult.tsx index db660c5c8fa..d5da1b8a51a 100644 --- a/client/search-ui/src/components/RepoSearchResult.tsx +++ b/client/search-ui/src/components/RepoSearchResult.tsx @@ -7,7 +7,6 @@ import SourceRepositoryIcon from 'mdi-react/SourceRepositoryIcon' import { highlightNode } from '@sourcegraph/common' import { codeHostSubstrLength, displayRepoName } from '@sourcegraph/shared/src/components/RepoLink' import { getRepoMatchLabel, getRepoMatchUrl, RepositoryMatch } from '@sourcegraph/shared/src/search/stream' -import { useCoreWorkflowImprovementsEnabled } from '@sourcegraph/shared/src/settings/useCoreWorkflowImprovementsEnabled' import { Icon, Link } from '@sourcegraph/wildcard' import { LastSyncedIcon } from './LastSyncedIcon' @@ -32,19 +31,12 @@ export const RepoSearchResult: React.FunctionComponent = as, index, }) => { - const [coreWorkflowImprovementsEnabled] = useCoreWorkflowImprovementsEnabled() const repoDescriptionElement = useRef(null) const repoNameElement = useRef(null) const renderTitle = (): JSX.Element => (
- + {displayRepoName(getRepoMatchLabel(result))} diff --git a/client/search-ui/src/components/ResultContainer.module.scss b/client/search-ui/src/components/ResultContainer.module.scss index ea5ad5873f1..795a3d1c57b 100644 --- a/client/search-ui/src/components/ResultContainer.module.scss +++ b/client/search-ui/src/components/ResultContainer.module.scss @@ -4,31 +4,22 @@ } &:not(:last-of-type) { - margin-bottom: 0.5rem; - } - - :global(.core-workflow-improvements-enabled) &:not(:last-of-type) { // Prevents the sticky items below from affecting // anything outside of the result container. isolation: isolate; - margin-bottom: 1rem; } } .header { padding: 0.5rem 0.5rem 0.5rem 0; - background-color: transparent; display: flex; align-items: center; flex-wrap: wrap; - - :global(.core-workflow-improvements-enabled) & { - position: sticky; - top: 0; - z-index: 1; // Show on top of search result contents - background-color: var(--body-bg); - } + position: sticky; + top: 0; + z-index: 1; // Show on top of search result contents + background-color: var(--body-bg); &-title { flex: 1 1 auto; diff --git a/client/search-ui/src/components/ResultContainer.tsx b/client/search-ui/src/components/ResultContainer.tsx index bbc150726c1..a9458bf64be 100644 --- a/client/search-ui/src/components/ResultContainer.tsx +++ b/client/search-ui/src/components/ResultContainer.tsx @@ -1,11 +1,10 @@ /* eslint jsx-a11y/click-events-have-key-events: warn, jsx-a11y/no-static-element-interactions: warn */ import React, { useCallback, useEffect, useRef, useState } from 'react' -import { mdiArrowCollapseUp, mdiChevronDown, mdiArrowExpandDown, mdiChevronLeft, mdiChevronUp } from '@mdi/js' +import { mdiChevronDown, mdiChevronUp } from '@mdi/js' import classNames from 'classnames' -import { useCoreWorkflowImprovementsEnabled } from '@sourcegraph/shared/src/settings/useCoreWorkflowImprovementsEnabled' -import { Button, Icon } from '@sourcegraph/wildcard' +import { Icon } from '@sourcegraph/wildcard' import { formatRepositoryStarCount } from '../util/stars' @@ -125,11 +124,9 @@ export const ResultContainer: React.FunctionComponent { - const [coreWorkflowImprovementsEnabled] = useCoreWorkflowImprovementsEnabled() const [expanded, setExpanded] = useState(allExpanded || defaultExpanded) const formattedRepositoryStarCount = formatRepositoryStarCount(repoStars) @@ -152,13 +148,13 @@ export const ResultContainer: React.FunctionComponent { const reducedMotion = !window.matchMedia('(prefers-reduced-motion: no-preference)').matches rootRef.current?.scrollIntoView({ block: 'nearest', behavior: reducedMotion ? 'auto' : 'smooth' }) }, 0) } - }, [collapsible, coreWorkflowImprovementsEnabled, expanded]) + }, [collapsible, expanded]) const trackReferencePanelClick = (): void => { if (onResultClicked) { @@ -177,22 +173,6 @@ export const ResultContainer: React.FunctionComponent
- {!coreWorkflowImprovementsEnabled && ( - <> - -
- - )}
{description} )}
- {!coreWorkflowImprovementsEnabled && matchCountLabel && ( - - {matchCountLabel} - {collapsible &&
} - - )} - {!coreWorkflowImprovementsEnabled && collapsible && ( - - )} - {!coreWorkflowImprovementsEnabled && matchCountLabel && formattedRepositoryStarCount && ( -
- )} {formattedRepositoryStarCount && ( @@ -246,14 +190,9 @@ export const ResultContainer: React.FunctionComponent )}
-
+
{expanded ? expandedChildren : collapsedChildren}
- {coreWorkflowImprovementsEnabled && collapsible && ( + {collapsible && ( - - - - )} - - )} +