artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 17:51:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove code host rate limit critical alerts (#39818)

Browse Source
This commit is contained in:
Michael Lin 2022-08-02 07:15:53 -07:00 committed by GitHub
parent 5fca3bc904
commit cfdd89cf75
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
doc/admin/observability/alerts.md
View File

@ -3803,7 +3803,6 @@ with your code hosts connections or networking issues affecting communication wi
**Descriptions**
- <span class="badge badge-warning">warning</span> repo-updater: less than 250 remaining calls to GitHub graphql API before hitting the rate limit
- <span class="badge badge-critical">critical</span> repo-updater: less than 250 remaining calls to GitHub graphql API before hitting the rate limit for 50m0s
**Next steps**
@ -3813,8 +3812,7 @@ with your code hosts connections or networking issues affecting communication wi
```json
"observability.silenceAlerts": [
"warning_repo-updater_github_graphql_rate_limit_remaining",
"critical_repo-updater_github_graphql_rate_limit_remaining"
"warning_repo-updater_github_graphql_rate_limit_remaining"
]
```
@ -3829,7 +3827,6 @@ with your code hosts connections or networking issues affecting communication wi
**Descriptions**
- <span class="badge badge-warning">warning</span> repo-updater: less than 250 remaining calls to GitHub rest API before hitting the rate limit
- <span class="badge badge-critical">critical</span> repo-updater: less than 250 remaining calls to GitHub rest API before hitting the rate limit for 50m0s
**Next steps**
@ -3839,8 +3836,7 @@ with your code hosts connections or networking issues affecting communication wi
```json
"observability.silenceAlerts": [
"warning_repo-updater_github_rest_rate_limit_remaining",
"critical_repo-updater_github_rest_rate_limit_remaining"
"warning_repo-updater_github_rest_rate_limit_remaining"
]
```
@ -3855,7 +3851,6 @@ with your code hosts connections or networking issues affecting communication wi
**Descriptions**
- <span class="badge badge-warning">warning</span> repo-updater: less than 5 remaining calls to GitHub search API before hitting the rate limit
- <span class="badge badge-critical">critical</span> repo-updater: less than 5 remaining calls to GitHub search API before hitting the rate limit for 50m0s
**Next steps**
@ -3865,8 +3860,7 @@ with your code hosts connections or networking issues affecting communication wi
```json
"observability.silenceAlerts": [
"warning_repo-updater_github_search_rate_limit_remaining",
"critical_repo-updater_github_search_rate_limit_remaining"
"warning_repo-updater_github_search_rate_limit_remaining"
]
```

6
doc/admin/observability/dashboards.md generated
View File

@ -12047,7 +12047,7 @@ Query: `max(src_repoupdater_errored_sync_jobs_percentage)`
<p class="subtitle">Remaining calls to GitHub graphql API before hitting the rate limit</p>
Refer to the [alerts reference](./alerts.md#repo-updater-github-graphql-rate-limit-remaining) for 2 alerts related to this panel.
Refer to the [alerts reference](./alerts.md#repo-updater-github-graphql-rate-limit-remaining) for 1 alert related to this panel.
To see this panel, visit `/-/debug/grafana/d/repo-updater/repo-updater?viewPanel=100220` on your Sourcegraph instance.
@ -12066,7 +12066,7 @@ Query: `max by (name) (src_github_rate_limit_remaining_v2{resource="graphql"})`
<p class="subtitle">Remaining calls to GitHub rest API before hitting the rate limit</p>
Refer to the [alerts reference](./alerts.md#repo-updater-github-rest-rate-limit-remaining) for 2 alerts related to this panel.
Refer to the [alerts reference](./alerts.md#repo-updater-github-rest-rate-limit-remaining) for 1 alert related to this panel.
To see this panel, visit `/-/debug/grafana/d/repo-updater/repo-updater?viewPanel=100221` on your Sourcegraph instance.
@ -12085,7 +12085,7 @@ Query: `max by (name) (src_github_rate_limit_remaining_v2{resource="rest"})`
<p class="subtitle">Remaining calls to GitHub search API before hitting the rate limit</p>
Refer to the [alerts reference](./alerts.md#repo-updater-github-search-rate-limit-remaining) for 2 alerts related to this panel.
Refer to the [alerts reference](./alerts.md#repo-updater-github-search-rate-limit-remaining) for 1 alert related to this panel.
To see this panel, visit `/-/debug/grafana/d/repo-updater/repo-updater?viewPanel=100222` on your Sourcegraph instance.

21
monitoring/definitions/repo_updater.go
View File

@ -393,11 +393,8 @@ func RepoUpdater() *monitoring.Dashboard {
Query: `max by (name) (src_github_rate_limit_remaining_v2{resource="graphql"})`,
// 5% of initial limit of 5000
Warning: monitoring.Alert().LessOrEqual(250),
// Critical if most of a 60-minute reset window is spent below
// the threshold.
Critical: monitoring.Alert().LessOrEqual(250).For(50 * time.Minute),
Panel: monitoring.Panel().LegendFormat("{{name}}"),
Owner: monitoring.ObservableOwnerRepoManagement,
Panel: monitoring.Panel().LegendFormat("{{name}}"),
Owner: monitoring.ObservableOwnerRepoManagement,
NextSteps: `
- Consider creating a new token for the indicated resource (the 'name' label for series below the threshold in the dashboard) under a dedicated machine user to reduce rate limit pressure.
`,
@ -408,11 +405,8 @@ func RepoUpdater() *monitoring.Dashboard {
Query: `max by (name) (src_github_rate_limit_remaining_v2{resource="rest"})`,
// 5% of initial limit of 5000
Warning: monitoring.Alert().LessOrEqual(250),
// Critical if most of a 60-minute reset window is spent below
// the threshold.
Critical: monitoring.Alert().LessOrEqual(250).For(50 * time.Minute),
Panel: monitoring.Panel().LegendFormat("{{name}}"),
Owner: monitoring.ObservableOwnerRepoManagement,
Panel: monitoring.Panel().LegendFormat("{{name}}"),
Owner: monitoring.ObservableOwnerRepoManagement,
NextSteps: `
- Consider creating a new token for the indicated resource (the 'name' label for series below the threshold in the dashboard) under a dedicated machine user to reduce rate limit pressure.
`,
@ -422,11 +416,8 @@ func RepoUpdater() *monitoring.Dashboard {
Description: "remaining calls to GitHub search API before hitting the rate limit",
Query: `max by (name) (src_github_rate_limit_remaining_v2{resource="search"})`,
Warning: monitoring.Alert().LessOrEqual(5),
// Critical if most of a 60-minute reset window is spent below
// the threshold.
Critical: monitoring.Alert().LessOrEqual(5).For(50 * time.Minute),
Panel: monitoring.Panel().LegendFormat("{{name}}"),
Owner: monitoring.ObservableOwnerRepoManagement,
Panel: monitoring.Panel().LegendFormat("{{name}}"),
Owner: monitoring.ObservableOwnerRepoManagement,
NextSteps: `
- Consider creating a new token for the indicated resource (the 'name' label for series below the threshold in the dashboard) under a dedicated machine user to reduce rate limit pressure.
`,