artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 13:11:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Chore: remove non-null assertions (#64249)

Browse Source 
Followup from #64236
This commit is contained in:
Camden Cheek 2024-08-02 15:01:48 -06:00 committed by GitHub
parent a148d8a670
commit c643c224ab
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 11 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
client/web-sveltekit/src/lib/codenav/ExplorePanel.svelte
View File

@ -51,13 +51,13 @@
const repoGroups: RepoGroup[] = []
for (const usage of usages) {
const repo = usage.usageRange!.repository
const repo = usage.usageRange.repository
if (seenRepos[repo] === undefined) {
seenRepos[repo] = { index: repoGroups.length, seenPaths: {} }
repoGroups.push({ repo, pathGroups: [] })
}
const path = usage.usageRange!.path
const path = usage.usageRange.path
const seenPaths = seenRepos[repo].seenPaths
const pathGroups = repoGroups[seenRepos[repo].index].pathGroups

22
client/web-sveltekit/src/lib/codenav/ExplorePanelFileUsages.svelte
View File

@ -16,12 +16,8 @@
export let usages: ExplorePanel_Usage[]
export let scrollContainer: HTMLElement | undefined
// TODO: remove all the usageRange! assertions once the backend is updated to
// use a non-nullable type in the API. I've already confirmed that it should always
// be non-null.
//
// FIXME: Assumes that all usages for a repo/path combo are at the same revision.
$: revision = usages[0].usageRange!.revision
$: revision = usages[0].usageRange.revision
let highlightedHTMLChunks: string[][] | undefined
let visible = false
@ -33,8 +29,8 @@
path: path,
},
ranges: usages.map(usage => ({
startLine: usage.usageRange!.range.start.line,
endLine: usage.usageRange!.range.end.line + 1,
startLine: usage.usageRange.range.start.line,
endLine: usage.usageRange.range.end.line + 1,
})),
})
.then(result => {
@ -44,7 +40,7 @@
}
function hrefForUsage(usage: ExplorePanel_Usage): string {
const { repository, revision, path, range } = usage.usageRange!
const { repository, revision, path, range } = usage.usageRange
return SourcegraphURL.from(`${repository}@${revision}/-/blob/${path}`)
.setLineRange({
line: range.start.line + 1,
@ -56,13 +52,13 @@
}
$: usageExcerpts = usages.map((usage, index) => ({
startLine: usage.usageRange!.range.start.line,
startLine: usage.usageRange.range.start.line,
matches: [
{
startLine: usage.usageRange!.range.start.line,
startCharacter: usage.usageRange!.range.start.character,
endLine: usage.usageRange!.range.end.line,
endCharacter: usage.usageRange!.range.end.character,
startLine: usage.usageRange.range.start.line,
startCharacter: usage.usageRange.range.start.character,
endLine: usage.usageRange.range.end.line,
endCharacter: usage.usageRange.range.end.character,
},
],
plaintextLines: [usage.surroundingContent],