From c62b27949908754cc412e48bb3e4eb005e8a776e Mon Sep 17 00:00:00 2001 From: Quinn Slack Date: Fri, 11 Jan 2019 11:35:58 -0800 Subject: [PATCH] make sourcegraph.Location fields readonly (#1696) --- packages/sourcegraph-extension-api/src/sourcegraph.d.ts | 4 ++-- shared/src/api/extension/types/location.ts | 7 ++----- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/packages/sourcegraph-extension-api/src/sourcegraph.d.ts b/packages/sourcegraph-extension-api/src/sourcegraph.d.ts index fad74a6670d..e295b4d0da3 100644 --- a/packages/sourcegraph-extension-api/src/sourcegraph.d.ts +++ b/packages/sourcegraph-extension-api/src/sourcegraph.d.ts @@ -304,12 +304,12 @@ declare module 'sourcegraph' { /** * The resource identifier of this location. */ - uri: URI + readonly uri: URI /** * The document range of this location. */ - range?: Range + readonly range?: Range /** * Creates a new location object. diff --git a/shared/src/api/extension/types/location.ts b/shared/src/api/extension/types/location.ts index 538a6bbfd6a..31b9e7c4213 100644 --- a/shared/src/api/extension/types/location.ts +++ b/shared/src/api/extension/types/location.ts @@ -14,12 +14,9 @@ export class Location implements sourcegraph.Location { return Range.isRange((thing as Location).range) && URI.isURI((thing as Location).uri) } - public uri: sourcegraph.URI - public range?: sourcegraph.Range - - constructor(uri: sourcegraph.URI, rangeOrPosition?: sourcegraph.Range | sourcegraph.Position) { - this.uri = uri + public readonly range?: sourcegraph.Range + constructor(public readonly uri: sourcegraph.URI, rangeOrPosition?: sourcegraph.Range | sourcegraph.Position) { if (!rangeOrPosition) { // that's OK } else if (rangeOrPosition instanceof Range) {