From bf65e1eb20a0ceb988e889e5752b6cc234524d1d Mon Sep 17 00:00:00 2001 From: Varun Gandhi Date: Fri, 3 Nov 2023 13:35:26 +0800 Subject: [PATCH] squirrel: Do case-insensitive comparison of file extensions (#58069) --- cmd/symbols/squirrel/language-file-extensions.json | 4 +--- cmd/symbols/squirrel/util.go | 5 ++++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/cmd/symbols/squirrel/language-file-extensions.json b/cmd/symbols/squirrel/language-file-extensions.json index f05fe872c2b..3e7b60147a5 100644 --- a/cmd/symbols/squirrel/language-file-extensions.json +++ b/cmd/symbols/squirrel/language-file-extensions.json @@ -51,9 +51,7 @@ "h++", "hh", "h", - "hpp", - "pc", - "pcc" + "hpp" ], "csharp": [ "cs", diff --git a/cmd/symbols/squirrel/util.go b/cmd/symbols/squirrel/util.go index e44019d0f2a..ed38e685c21 100644 --- a/cmd/symbols/squirrel/util.go +++ b/cmd/symbols/squirrel/util.go @@ -246,7 +246,10 @@ func (s *SquirrelService) parse(ctx context.Context, repoCommitPath types.RepoCo ext = strings.TrimPrefix(filepath.Ext(repoCommitPath.Path), ".") } - langName, ok := extToLang[ext] + // It is not uncommon to have files with upper-case extensions + // like .C, .H, .CPP etc., especially for code developed on + // case-insensitive filesystems. + langName, ok := extToLang[strings.ToLower(ext)] if !ok { return nil, unrecognizedFileExtensionError }