artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 12:51:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(svelte): Use MDI icons for seach input pattern type toggles (#63733)

Browse Source 
We don't like the style/alignment of the Lucide case sensitivity and
regex icons (the structural search icon seems fine). This commit
switches them back to the MDI icons that we used before.

Solution or temporary workaround (tbd) for srch-544


## Test plan

Manual testing.
This commit is contained in:
Felix Kling 2024-07-09 23:56:00 +02:00 committed by GitHub
parent 4c3985e16f
commit b9dd3a774d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
client/web-sveltekit/BUILD.bazel
View File

@ -92,6 +92,7 @@ BUILD_DEPS = [
":node_modules/@iconify-json/devicon-plain",
":node_modules/@iconify-json/file-icons",
":node_modules/@iconify-json/lucide",
":node_modules/@iconify-json/mdi",
":node_modules/@iconify-json/ph",
":node_modules/@iconify-json/simple-icons",
":node_modules/@melt-ui/svelte",

1
client/web-sveltekit/package.json
View File

@ -34,6 +34,7 @@
"@iconify-json/devicon-plain": "^1.1.42",
"@iconify-json/file-icons": "^1.1.8",
"@iconify-json/lucide": "^1.1.188",
"@iconify-json/mdi": "^1.1.67",
"@iconify-json/ph": "^1.1.13",
"@iconify-json/simple-icons": "^1.1.104",
"@playwright/test": "1.42.1",

2
client/web-sveltekit/src/auto-imports.d.ts vendored
View File

@ -88,6 +88,8 @@ declare global {
const ILucideWrapText: typeof import('~icons/lucide/wrap-text')['default']
const ILucideX: typeof import('~icons/lucide/x')['default']
const ILucidehevronLeft: typeof import('~icons/lucide/hevron-left')['default']
const IMdiFormatLetterCase: typeof import('~icons/mdi/format-letter-case')['default']
const IMdiRegex: typeof import('~icons/mdi/regex')['default']
const IPhFileJpgLight: typeof import('~icons/ph/file-jpg-light')['default']
const IPhFilePngLight: typeof import('~icons/ph/file-png-light')['default']
const IPhGifFill: typeof import('~icons/ph/gif-fill')['default']

4
client/web-sveltekit/src/lib/search/input/SearchInput.svelte
View File

@ -272,7 +272,7 @@
class:active={$queryState.caseSensitive}
on:click={() => queryState.setCaseSensitive(caseSensitive => !caseSensitive)}
>
<Icon icon={ILucideCaseSensitive} inline aria-hidden />
<Icon icon={IMdiFormatLetterCase} inline aria-hidden />
</button>
</Tooltip>
<Tooltip tooltip="{regularExpressionEnabled ? 'Disable' : 'Enable'} regular expression">
@ -282,7 +282,7 @@
class:active={regularExpressionEnabled}
on:click={() => setOrUnsetPatternType(SearchPatternType.regexp)}
>
<Icon icon={ILucideRegex} inline aria-hidden />
<Icon icon={IMdiRegex} inline aria-hidden />
</button>
</Tooltip>
{#if structuralEnabled}

9
pnpm-lock.yaml
View File

@ -1660,6 +1660,9 @@ importers:
'@iconify-json/lucide':
specifier: ^1.1.188
version: 1.1.188
'@iconify-json/mdi':
specifier: ^1.1.67
version: 1.1.67
'@iconify-json/ph':
specifier: ^1.1.13
version: 1.1.13
@ -5556,6 +5559,12 @@ packages:
'@iconify/types': 2.0.0
dev: true
/@iconify-json/mdi@1.1.67:
resolution: {integrity: sha512-00nllHES8hyACwIfgySlQgAE6MKgpr2wsKfpifMiZWZ9aXC5l4Jb0lR3lJSWwXgOW6kzAOdzC3T+2VOfBBZ13A==}
dependencies:
'@iconify/types': 2.0.0
dev: true
/@iconify-json/ph@1.1.13:
resolution: {integrity: sha512-xtM4JJ63HCKj09WRqrBswXiHrpliBlqboWSZH8odcmqYXbvIFceU9/Til4V+MQr6+MoUC+KB72cxhky2+A6r/g==}
dependencies: