artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 17:11:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ci): only emit bazel execlog artifact for 'test' commands (#63916)

Browse Source 
Delivery Manifest step has started to run `bazel build` commands, in them clobbering our execlog artifacts. We should only emit it for the test buildkite jobs (at least for the time being), as it currently doesnt make sense for e.g. the image push jobs which contain multiple invocations

## Test plan

CI

## Changelog
This commit is contained in:
Noah S-C 2024-07-18 15:17:12 +01:00 committed by GitHub
parent 51bc688ec9
commit b7dac3b808
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.aspect/bazelrc/ci.sourcegraph.bazelrc
View File

@ -59,7 +59,6 @@ test --build_event_binary_file_path_conversion=false
test --build_event_binary_file_upload_mode=wait_for_upload_complete
test --build_event_publish_all_actions=true
build --experimental_execution_log_compact_file=execution_log.zstd
test --experimental_execution_log_compact_file=execution_log.zstd
# These likely perform faster locally than the overhead of pulling/pushing from/to the remote cache,

2
dev/ci/internal/ci/images_operations.go
View File

@ -132,7 +132,7 @@ func bazelPushImagesCmd(c Config, isCandidate bool, opts ...bk.StepOpt) func(*bk
bk.Env("PROD_REGISTRY", prodRegistry),
bk.Env("ADDITIONAL_PROD_REGISTRIES", additionalProdRegistry),
bk.Cmd(bazelStampedCmd(fmt.Sprintf(`build $$(bazel --bazelrc=%s --bazelrc=.aspect/bazelrc/ci.sourcegraph.bazelrc query 'kind("oci_push rule", //...)')`, bazelRC))),
bk.ArtifactPaths("build_event_log.bin", "execution_log.zstd"),
bk.ArtifactPaths("build_event_log.bin"),
bk.AnnotatedCmd(
"./dev/ci/push_all.sh",
bk.AnnotatedCmdOpts{