From b05bd5bb16ca89928d060b1574f51e5d765657a0 Mon Sep 17 00:00:00 2001 From: Felix Kling Date: Thu, 20 Jun 2024 17:44:32 +0200 Subject: [PATCH] fix(svelte): Open correct file from preview panel line number (#63309) Fixes srch-553 This commit changes the "selectline" handler to open the correct file when the file view is embedded. ## Test plan Manual testing. Open reference panel, click on reference to open preview panel, click on line number in review panel. --- .../(validrev)/(code)/-/blob/[...path]/FileView.svelte | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/client/web-sveltekit/src/routes/[...repo=reporev]/(validrev)/(code)/-/blob/[...path]/FileView.svelte b/client/web-sveltekit/src/routes/[...repo=reporev]/(validrev)/(code)/-/blob/[...path]/FileView.svelte index 41cf0d827c3..3b83c0f1515 100644 --- a/client/web-sveltekit/src/routes/[...repo=reporev]/(validrev)/(code)/-/blob/[...path]/FileView.svelte +++ b/client/web-sveltekit/src/routes/[...repo=reporev]/(validrev)/(code)/-/blob/[...path]/FileView.svelte @@ -272,9 +272,10 @@ selectedLines={selectedPosition?.line ? selectedPosition : null} on:selectline={({ detail: range }) => { goto( - SourcegraphURL.from($page.url.searchParams) + SourcegraphURL.from(embedded ? `${repoURL}/-/blob/${filePath}` : $page.url.searchParams) .setLineRange(range ? { line: range.line, endLine: range.endLine } : null) - .deleteSearchParameter('popover').search + .deleteSearchParameter('popover') + .toString() ) }} {codeIntelAPI}