artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 19:21:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

jscontext: Use faster, non-blocking method to determine initialized state (#49336)

Browse Source 
The Get method ensures the site id has been generated already, which
requires a transaction and effectively sequentializes page loads across
frontend instances. This is a simple read and will not block. I've seen
120k of these queries in 1h on dotcom, and they had pretty bad lock
contention, effectively on average making page loads 17ms slower in that
window, according to query insights. This doesn't happen often, but
still a small improvement maybe?
This commit is contained in:
Erik Seliger 2023-03-15 01:38:57 +01:00 committed by GitHub
parent fc710e52b5
commit ab3e51d6e9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/frontend/internal/app/jscontext/jscontext.go
View File

@ -226,8 +226,8 @@ func NewJSContextFromRequest(req *http.Request, db database.DB) JSContext {
siteID := siteid.Get()
// Show the site init screen?
globalState, err := db.GlobalState().Get(ctx)
needsSiteInit := err == nil && !globalState.Initialized
siteInitialized, err := db.GlobalState().SiteInitialized(ctx)
needsSiteInit := err == nil && !siteInitialized
// Auth providers
var authProviders []authProviderInfo

7
internal/database/global_state.go
View File

@ -94,11 +94,7 @@ func (g *globalStateStore) SiteInitialized(ctx context.Context) (bool, error) {
return alreadyInitialized, err
}
var globalStateSiteInitializedQuery = fmt.Sprintf(`
%s
`,
globalStateInitializedFragment,
)
var globalStateSiteInitializedQuery = globalStateInitializedFragment
func (g *globalStateStore) EnsureInitialized(ctx context.Context) (_ bool, err error) {
if err := g.initializeDBState(ctx); err != nil {
@ -133,7 +129,6 @@ func (g *globalStateStore) initializeDBState(ctx context.Context) (err error) {
return err
}
defer func() { err = tx.Done(err) }()
if err := tx.Exec(ctx, sqlf.Sprintf(globalStateInitializeDBStateUpdateQuery)); err != nil {
return err
}