artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 15:51:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

codeintel-qa: more descriptive failure message (#25806)

Browse Source
This commit is contained in:
Chris Wendt 2021-10-07 14:00:26 -06:00 committed by GitHub
parent 70abe56b2f
commit a993190368
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
dev/codeintel-qa/cmd/query/queries.go
View File

@ -18,20 +18,20 @@ func buildQueries() <-chan queryFunc {
for _, testCase := range testCases {
// Definition returns defintion
fns <- makeTestFunc(queryDefinitions, testCase.Definition, []Location{testCase.Definition})
fns <- makeTestFunc("def -> def", queryDefinitions, testCase.Definition, []Location{testCase.Definition})
// References return definition
for _, reference := range testCase.References {
fns <- makeTestFunc(queryDefinitions, reference, []Location{testCase.Definition})
fns <- makeTestFunc("refs -> def", queryDefinitions, reference, []Location{testCase.Definition})
}
// Definition returns references
fns <- makeTestFunc(queryReferences, testCase.Definition, testCase.References)
fns <- makeTestFunc("def -> refs", queryReferences, testCase.Definition, testCase.References)
// References return references
if queryReferencesOfReferences {
for _, reference := range testCase.References {
fns <- makeTestFunc(queryReferences, reference, testCase.References)
fns <- makeTestFunc("refs -> refs", queryReferences, reference, testCase.References)
}
}
}
@ -46,7 +46,7 @@ type testFunc func(ctx context.Context, location Location) ([]Location, error)
// source, then compares the result against the set of expected locations. This function
// depends on the flags provided by the user to alter the behavior of the testing
// functions.
func makeTestFunc(f testFunc, source Location, expectedLocations []Location) func(ctx context.Context) error {
func makeTestFunc(name string, f testFunc, source Location, expectedLocations []Location) func(ctx context.Context) error {
return func(ctx context.Context) error {
locations, err := f(ctx, source)
if err != nil {
@ -57,7 +57,7 @@ func makeTestFunc(f testFunc, source Location, expectedLocations []Location) fun
sortLocations(locations)
if diff := cmp.Diff(expectedLocations, locations); diff != "" {
return errors.Errorf("unexpected locations (-want +got):\n%s", diff)
return errors.Errorf("%s: starting at location\n\n %+v\n\ngot unexpected locations (-want +got):\n%s", name, source, diff)
}
}