release: fix error handling with sg release (#62244)

more regression fix
This commit is contained in:
Bolaji Olajide 2024-04-29 16:16:34 +01:00 committed by GitHub
parent 487682a99b
commit a70c412b3a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -330,7 +330,7 @@ func (r *releaseRunner) CreateRelease(ctx context.Context) error {
func (r *releaseRunner) InternalFinalize(ctx context.Context) error {
if err := r.checkRequirements(ctx, stageInternalCreate); err != nil {
return nil
return err
}
if len(r.m.Internal.Finalize.Steps) == 0 {
@ -343,7 +343,7 @@ func (r *releaseRunner) InternalFinalize(ctx context.Context) error {
func (r *releaseRunner) Test(ctx context.Context) error {
if err := r.checkRequirements(ctx, stageTest); err != nil {
return nil
return err
}
if len(r.m.Test.Steps) == 0 {
@ -356,7 +356,7 @@ func (r *releaseRunner) Test(ctx context.Context) error {
func (r *releaseRunner) Promote(ctx context.Context) error {
if err := r.checkRequirements(ctx, stagePromoteCreate); err != nil {
return nil
return err
}
announce2("promote", "Will promote %q to a public release", r.version)
return r.runSteps(ctx, r.m.PromoteToPublic.Create.Steps)
@ -364,7 +364,7 @@ func (r *releaseRunner) Promote(ctx context.Context) error {
func (r *releaseRunner) PromoteFinalize(ctx context.Context) error {
if err := r.checkRequirements(ctx, stagePromoteFinalize); err != nil {
return nil
return err
}
if len(r.m.PromoteToPublic.Finalize.Steps) == 0 {