From a2e9b12cc9ff7500487592fc185c0cb276b40361 Mon Sep 17 00:00:00 2001 From: Quinn Slack Date: Sat, 21 Oct 2023 15:37:49 -0700 Subject: [PATCH] disable eslint rule etc/no-deprecated for massive file save speedup (#57782) With this rule enabled, saving a file in VS Code often takes 2-5 seconds or longer. With it disabled, saving a file is usually instant. This rule is identified as the biggest culprit in slow eslint analysis by running `TIMING=1 pnpm exec eslint --fix client/web/dev/server/development.server.ts`. --- .eslintrc.js | 1 + .../codeintel/legacy-extensions/lsif/definition-hover.test.ts | 1 - .../src/codeintel/legacy-extensions/lsif/providers.test.ts | 1 - .../src/codeintel/legacy-extensions/lsif/references.test.ts | 1 - .../src/codeintel/legacy-extensions/search/providers.test.ts | 1 - 5 files changed, 1 insertion(+), 4 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index e603fc62054..199e7a15aba 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -242,6 +242,7 @@ See https://handbook.sourcegraph.com/community/faq#is-all-of-sourcegraph-open-so }, ], 'import/order': 'off', + 'etc/no-deprecated': 'off', }, overrides: [ { diff --git a/client/shared/src/codeintel/legacy-extensions/lsif/definition-hover.test.ts b/client/shared/src/codeintel/legacy-extensions/lsif/definition-hover.test.ts index c9d25fcd839..0eace86e2bf 100644 --- a/client/shared/src/codeintel/legacy-extensions/lsif/definition-hover.test.ts +++ b/client/shared/src/codeintel/legacy-extensions/lsif/definition-hover.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable etc/no-deprecated */ import * as assert from 'assert' import * as sinon from 'sinon' diff --git a/client/shared/src/codeintel/legacy-extensions/lsif/providers.test.ts b/client/shared/src/codeintel/legacy-extensions/lsif/providers.test.ts index 3914406e6da..89a51325488 100644 --- a/client/shared/src/codeintel/legacy-extensions/lsif/providers.test.ts +++ b/client/shared/src/codeintel/legacy-extensions/lsif/providers.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable etc/no-deprecated */ import * as assert from 'assert' import * as sinon from 'sinon' diff --git a/client/shared/src/codeintel/legacy-extensions/lsif/references.test.ts b/client/shared/src/codeintel/legacy-extensions/lsif/references.test.ts index fde0a9870bb..9a212fa6107 100644 --- a/client/shared/src/codeintel/legacy-extensions/lsif/references.test.ts +++ b/client/shared/src/codeintel/legacy-extensions/lsif/references.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable etc/no-deprecated */ import * as assert from 'assert' import * as sinon from 'sinon' diff --git a/client/shared/src/codeintel/legacy-extensions/search/providers.test.ts b/client/shared/src/codeintel/legacy-extensions/search/providers.test.ts index 2da6fbf21b8..4d393b59f64 100644 --- a/client/shared/src/codeintel/legacy-extensions/search/providers.test.ts +++ b/client/shared/src/codeintel/legacy-extensions/search/providers.test.ts @@ -1,4 +1,3 @@ -/* eslint-disable etc/no-deprecated */ import * as assert from 'assert' import * as sinon from 'sinon'