artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 11:01:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

vitest: Fix workspace config wrt client/web/ (#58397)

Browse Source 
It appears that the workspace configuration is somehow broken because it
doesn't include any tests defined in `client/web/src/`. This can be
tested by filtering for a test inside this subtree, for example

    pnpm exec vitest RepoRevisionSidebar

vitest will error saying it didn't find any tests. The list of projects
it prints also doesn't include `web`.

I don't know what exactly it is that makes it exclude `client/web/` but
with the simpler version in this PR `client/web/` will be included.

I removed `client/web/dev/` from the list because it will be included by
`client/web/` too and seems to "just work" even though it has it's own
configuration file.
This commit is contained in:
Felix Kling 2023-11-17 09:22:46 +01:00 committed by GitHub
parent cb068f3c98
commit 9b9bd4387c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
vitest.workspace.ts
View File

@ -1,18 +1,16 @@
import { readFileSync, existsSync } from 'fs'
import { readFileSync } from 'fs'
import path from 'path'
import glob from 'glob'
import { load } from 'js-yaml'
import { defineWorkspace } from 'vitest/config'
interface PnpmWorkspaceFile {
packages: string[]
}
const workspaceFile = load(readFileSync(path.join(__dirname, 'pnpm-workspace.yaml'), 'utf8')) as PnpmWorkspaceFile
workspaceFile.packages.push('client/web/dev') // is a tsconfig project but not a pnpm workspace package
const projectRoots = workspaceFile.packages
.flatMap(p => glob.sync(`${p}/`, { cwd: __dirname }))
.map(p => p.replace(/\/$/, ''))
.filter(dir => existsSync(path.join(dir, 'vitest.config.ts')))
export default defineWorkspace(projectRoots)
function fromPnpmWorkspaceFile(filePath: string): string[] {
return (load(readFileSync(filePath, 'utf8')) as PnpmWorkspaceFile).packages.map(p => `${p}/vitest.config.ts`, {
cwd: __dirname,
})
}
export default fromPnpmWorkspaceFile(path.join(__dirname, 'pnpm-workspace.yaml'))