artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 12:51:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

schema: remove non-determinism from TestSchemaValidationUUID (#61728)

Browse Source 
Noticed this test failing once locally and worked out the source of the
flakiness. Could reproduce with the below test plan.

Test Plan: "go test -race -count=100 ./schema" passes
This commit is contained in:
Keegan Carruthers-Smith 2024-04-09 17:50:30 +02:00 committed by GitHub
parent f63cda7b30
commit 65ebdfb8af
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
schema/validation_test.go
View File

@ -1,6 +1,7 @@
package schema
import (
"sort"
"strings"
"testing"
@ -67,7 +68,15 @@ func TestSchemaValidationUUID(t *testing.T) {
* uuid-escaped: Does not match pattern '^\{[0-9a-fA-F]{8}\-[0-9a-fA-F]{4}\-[0-9a-fA-F]{4}\-[0-9a-fA-F]{4}\-[0-9a-fA-F]{12}\}$'
* uuid-unescaped: Does not match pattern '^\{[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}\}$'`
if diff := cmp.Diff(err.Error(), wantErr); diff != "" {
// order of errors is not deterministic due to internal use of go
// maps.
sortedLines := func(s string) string {
lines := strings.Split(s, "\n")
sort.Strings(lines)
return strings.Join(lines, "\n")
}
if diff := cmp.Diff(sortedLines(err.Error()), sortedLines(wantErr)); diff != "" {
t.Fatalf("wrong error message: %s", diff)
}
})