artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 17:31:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

No-op extensions controller should mark initial extensions as loaded (#41300)

Browse Source 
This was an oversight when I created the no-op extensions controller
that was discovered while I fixed tests for #41129.

When the no-op extensions controller is enabled, the actions sidebar is
stuck in the loading state because the subscribeable is never updated. 

Since there are no extensions to load in this version, we can always
mark them as loaded right away.
This commit is contained in:
Philipp Spiess 2022-09-05 12:14:41 +02:00 committed by GitHub
parent ade60d6dc7
commit 65daae3701
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
client/shared/src/extensions/createNoopLoadedController.ts.ts
View File

@ -32,6 +32,9 @@ export function createNoopController(platformContext: PlatformContext): Controll
)
const extensionHostAPI = pretendRemote(createExtensionHostAPI(extensionHostState))
// We don't have to load any extensions so we are already done
extensionHostState.haveInitialExtensionsLoaded.next(true)
resolve(extensionHostAPI)
})
}),