artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 15:51:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: better alignemnt of github credentials and check success notice (#63717)

Browse Source 
Closes SRCH-701

Ideally we would use a DismissibleAlert one level up the React component
chain, but that's turning out too tricky for the time we have left:
https://sourcegraph.slack.com/archives/C07A21XEP0T/p1720486350310899

## Test plan

Manual testing

## Changelog

<!-- OPTIONAL; info at
https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c
-->
This commit is contained in:
Michael Bahr 2024-07-09 17:02:25 +02:00 committed by GitHub
parent 1261b06e36
commit 62b0c89dbb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
client/web/src/enterprise/batches/settings/CodeHostConnectionNode.tsx
View File

@ -146,7 +146,7 @@ export const CodeHostConnectionNode: React.FunctionComponent<React.PropsWithChil
</Badge>
)}
</H3>
<div className="mb-0 d-flex justify-content-end flex-grow-1 align-items-baseline">
<div className="mb-0 d-flex justify-content-end flex-grow-1 align-items-baseline flex-wrap">
{isEnabled ? (
gitHubApp ? (
<GitHubAppControls

14
client/web/src/enterprise/batches/settings/GitHubAppControls.tsx
View File

@ -66,7 +66,7 @@ export const GitHubAppControls: React.FunctionComponent<GitHubAppControlsProps>
>(CHECK_BATCH_CHANGES_CREDENTIAL, {})
return config ? (
<>
<div>
{removeModalOpen && (
<RemoveGitHubAppModal onCancel={() => setRemoveModalOpen(false)} afterDelete={refetch} app={config} />
)}
@ -140,11 +140,15 @@ export const GitHubAppControls: React.FunctionComponent<GitHubAppControlsProps>
</NodeAlert>
)}
{!checkCredLoading && (checkCredResult || checkCredErr) && (
<NodeAlert variant={checkCredErr ? 'danger' : 'success'}>
<span className="font-weight-bold">"{config.name}"</span> is {checkCredErr ? 'not' : ''} accessible.
</NodeAlert>
<>
<br />
<NodeAlert variant={checkCredErr ? 'danger' : 'success'}>
<span className="font-weight-bold">{config.name}</span> is {checkCredErr ? 'not' : ''}{' '}
accessible.
</NodeAlert>
</>
)}
</>
</div>
) : (
<ButtonLink to={createURL} className="ml-auto text-nowrap" variant="success" as={Link} size="sm">
Create GitHub App