artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 17:11:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Deactivate Firefox e2e and release steps (#13846)

Browse Source 
Only run browser extension e2e steps on Chrome: I'm going a bit crazy seeing the nightly test run failures.

Also de-activate FF release steps, as they will always fail until our add-on is unblocked. This means we can have successful bext release builds again.
This commit is contained in:
Loïc Guychard 2020-09-16 18:38:04 +02:00 committed by GitHub
parent c1200f2cb9
commit 57b88bf529
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 21 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
enterprise/dev/ci/ci/pipeline-steps.go
View File

@ -188,21 +188,21 @@ func addBackendIntegrationTests(c Config) func(*bk.Pipeline) {
}
func addBrowserExtensionE2ESteps(pipeline *bk.Pipeline) {
for _, browser := range []string{"chrome", "firefox"} {
// Run e2e tests
pipeline.AddStep(fmt.Sprintf(":%s:", browser),
bk.Env("PUPPETEER_SKIP_CHROMIUM_DOWNLOAD", ""),
bk.Env("EXTENSION_PERMISSIONS_ALL_URLS", "true"),
bk.Env("BROWSER", browser),
bk.Env("LOG_BROWSER_CONSOLE", "true"),
bk.Env("SOURCEGRAPH_BASE_URL", "https://sourcegraph.com"),
bk.Cmd("yarn --frozen-lockfile --network-timeout 60000"),
bk.Cmd("pushd browser"),
bk.Cmd("yarn -s run build"),
bk.Cmd("yarn -s mocha ./src/end-to-end/github.test.ts ./src/end-to-end/gitlab.test.ts"),
bk.Cmd("popd"),
bk.ArtifactPaths("./puppeteer/*.png"))
}
// TODO run this on firefox as well when our add-on is unblocked
browser := "chrome"
// Run e2e tests
pipeline.AddStep(fmt.Sprintf(":%s:", browser),
bk.Env("PUPPETEER_SKIP_CHROMIUM_DOWNLOAD", ""),
bk.Env("EXTENSION_PERMISSIONS_ALL_URLS", "true"),
bk.Env("BROWSER", browser),
bk.Env("LOG_BROWSER_CONSOLE", "true"),
bk.Env("SOURCEGRAPH_BASE_URL", "https://sourcegraph.com"),
bk.Cmd("yarn --frozen-lockfile --network-timeout 60000"),
bk.Cmd("pushd browser"),
bk.Cmd("yarn -s run build"),
bk.Cmd("yarn -s mocha ./src/end-to-end/github.test.ts ./src/end-to-end/gitlab.test.ts"),
bk.Cmd("popd"),
bk.ArtifactPaths("./puppeteer/*.png"))
}
// Release the browser extension.
@ -219,12 +219,13 @@ func addBrowserExtensionReleaseSteps(pipeline *bk.Pipeline) {
bk.Cmd("yarn release:chrome"),
bk.Cmd("popd"))
// TODO uncomment this when our add-on will be unblocked
// Build and self sign the FF extension and upload it to ...
pipeline.AddStep(":rocket::firefox:",
bk.Cmd("yarn --frozen-lockfile --network-timeout 60000"),
bk.Cmd("pushd browser"),
bk.Cmd("yarn release:ff"),
bk.Cmd("popd"))
// pipeline.AddStep(":rocket::firefox:",
// bk.Cmd("yarn --frozen-lockfile --network-timeout 60000"),
// bk.Cmd("pushd browser"),
// bk.Cmd("yarn release:ff"),
// bk.Cmd("popd"))
// Release to npm
pipeline.AddStep(":rocket::npm:",