From 4c23391014ecbc0159e5c64f55e95f8de9cef718 Mon Sep 17 00:00:00 2001 From: Quinn Slack Date: Mon, 9 Oct 2023 01:56:08 -0700 Subject: [PATCH] temporarily disable Chromatic upload that is failing on main (#57455) Failure example: https://buildkite.com/sourcegraph/sourcegraph/builds/246235#018b0c9a-38be-43ed-af9e-d8cf04ab7305 --- dev/ci/internal/ci/operations.go | 6 ++++-- doc/dev/background-information/ci/reference.md | 16 ++++++++-------- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/dev/ci/internal/ci/operations.go b/dev/ci/internal/ci/operations.go index 222cb76f15c..0e8a4721a67 100644 --- a/dev/ci/internal/ci/operations.go +++ b/dev/ci/internal/ci/operations.go @@ -321,8 +321,10 @@ func clientChromaticTests(opts CoreTestOperationsOptions) operations.Operation { chromaticCommand += " | ./dev/ci/post-chromatic.sh" } - pipeline.AddStep(":chromatic: Upload Storybook to Chromatic", - append(stepOpts, bk.Cmd(chromaticCommand))...) + // TODO(sqs): build is failing (https://buildkite.com/sourcegraph/sourcegraph/builds/246235#018b0c9a-38be-43ed-af9e-d8cf04ab7305) + _ = stepOpts + _ = chromaticCommand + // pipeline.AddStep(":chromatic: Upload Storybook to Chromatic", append(stepOpts, bk.Cmd(chromaticCommand))...) } } diff --git a/doc/dev/background-information/ci/reference.md b/doc/dev/background-information/ci/reference.md index ad3c7161b68..39579193e59 100644 --- a/doc/dev/background-information/ci/reference.md +++ b/doc/dev/background-information/ci/reference.md @@ -29,7 +29,7 @@ The default run type. - Tests - Async BackCompat Tests - **Linters and static analysis**: Run sg lint - - **Client checks**: Upload Storybook to Chromatic, Enterprise build, Build (client/jetbrains), Tests for VS Code extension, Stylelint (all) + - **Client checks**: Enterprise build, Build (client/jetbrains), Tests for VS Code extension, Stylelint (all) - **Security Scanning**: Sonarcloud Scan - **Pipeline setup**: Trigger async @@ -37,7 +37,7 @@ The default run type. - Perform bazel prechecks - Tests - Async BackCompat Tests - - **Client checks**: Upload Storybook to Chromatic, Enterprise build, Build (client/jetbrains), Tests for VS Code extension, Stylelint (all) + - **Client checks**: Enterprise build, Build (client/jetbrains), Tests for VS Code extension, Stylelint (all) - **Security Scanning**: Sonarcloud Scan - Pipeline for `DatabaseSchema` changes: @@ -141,7 +141,7 @@ Base pipeline (more steps might be included based on branch changes): - Tests - Async BackCompat Tests - **Linters and static analysis**: Run sg lint -- **Client checks**: Upload Storybook to Chromatic, Enterprise build, Build (client/jetbrains), Tests for VS Code extension, Stylelint (all) +- **Client checks**: Enterprise build, Build (client/jetbrains), Tests for VS Code extension, Stylelint (all) - **Security Scanning**: Sonarcloud Scan - **Publish candidate images**: Push candidate Images - **End-to-end tests**: Executors E2E @@ -203,7 +203,7 @@ Base pipeline (more steps might be included based on branch changes): - Tests - Async BackCompat Tests - **Linters and static analysis**: Run sg lint -- **Client checks**: Upload Storybook to Chromatic, Enterprise build, Build (client/jetbrains), Tests for VS Code extension, Stylelint (all) +- **Client checks**: Enterprise build, Build (client/jetbrains), Tests for VS Code extension, Stylelint (all) - **Security Scanning**: Sonarcloud Scan - **Publish candidate images**: Push candidate Images - **End-to-end tests**: Executors E2E @@ -221,7 +221,7 @@ Base pipeline (more steps might be included based on branch changes): - Tests - Async BackCompat Tests - **Linters and static analysis**: Run sg lint -- **Client checks**: Upload Storybook to Chromatic, Enterprise build, Build (client/jetbrains), Tests for VS Code extension, Stylelint (all) +- **Client checks**: Enterprise build, Build (client/jetbrains), Tests for VS Code extension, Stylelint (all) - **Security Scanning**: Sonarcloud Scan - **Publish candidate images**: Push candidate Images - **End-to-end tests**: Executors E2E @@ -262,7 +262,7 @@ Base pipeline (more steps might be included based on branch changes): - Tests - Async BackCompat Tests - **Linters and static analysis**: Run sg lint -- **Client checks**: Upload Storybook to Chromatic, Enterprise build, Build (client/jetbrains), Tests for VS Code extension, Stylelint (all) +- **Client checks**: Enterprise build, Build (client/jetbrains), Tests for VS Code extension, Stylelint (all) - **Security Scanning**: Sonarcloud Scan - **Publish candidate images**: Push candidate Images - **End-to-end tests**: Executors E2E @@ -285,7 +285,7 @@ Base pipeline (more steps might be included based on branch changes): - Tests - Async BackCompat Tests - **Linters and static analysis**: Run sg lint -- **Client checks**: Upload Storybook to Chromatic, Enterprise build, Build (client/jetbrains), Tests for VS Code extension, Stylelint (all) +- **Client checks**: Enterprise build, Build (client/jetbrains), Tests for VS Code extension, Stylelint (all) - **Security Scanning**: Sonarcloud Scan - **Publish candidate images**: Push candidate Images - **End-to-end tests**: Executors E2E @@ -361,7 +361,7 @@ Base pipeline (more steps might be included based on branch changes): - Tests - Async BackCompat Tests - **Linters and static analysis**: Run sg lint -- **Client checks**: Upload Storybook to Chromatic, Enterprise build, Build (client/jetbrains), Tests for VS Code extension, Stylelint (all) +- **Client checks**: Enterprise build, Build (client/jetbrains), Tests for VS Code extension, Stylelint (all) - **Security Scanning**: Sonarcloud Scan - **Publish candidate images**: Push candidate Images - **End-to-end tests**: Executors E2E