artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 17:31:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: set timeout for web-sveltekit/unit_tests to moderate (#63879)

Browse Source 
The unit tests for web-sveltekit have become flaky, and have therefore
been set to run only manually:
https://github.com/sourcegraph/sourcegraph/pull/63874

By running them via `sg ci bazel` I noticed in the waterfall view, that
the tests are taking slightly above one minute
(https://buildkite.com/sourcegraph/sourcegraph/builds/282732/waterfall),
and that previous tests failed because it exceeded a timeout of 1
minute: https://buildkite.com/sourcegraph/sourcegraph/builds/282684

It looks to me like the CI agents are a bit less powerful, and therefore
take longer than our local test runs (which usually don't exceed 10
seconds).

I have not investigated parallelizing the vitest workers, because for
web-sveltekit we currently only have a vite config, but not a vitest
config. More context on that here:
https://github.com/sourcegraph/sourcegraph/pull/60927

## Test plan

CI

## Changelog

<!-- OPTIONAL; info at
https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c
-->
This commit is contained in:
Michael Bahr 2024-07-17 16:01:36 +02:00 committed by GitHub
parent f3cc352da7
commit 4823c2fc2c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
client/web-sveltekit/BUILD.bazel
View File

@ -242,12 +242,12 @@ TEST_BUILD_DEPS = [
vitest_test(
name = "unit_tests",
timeout = "moderate",
bin = vitest_bin,
chdir = package_name(),
data = SRCS + BUILD_DEPS + CONFIGS + TESTS + TEST_BUILD_DEPS,
tags = [
TAG_SEARCHSUITE,
"manual",
],
with_vitest_config = False,
)