artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 16:51:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

appliance: remove default deployment replica scale (#62239)

Browse Source 
The default is 1 anyway, and if this field is explicitly set but also
managed by an HPA, configuration changes will cause downscale events.
Even when the HPA subsequently scales back out, there may have been a
period of service disruption as requests saturate the single replica.
This commit is contained in:
Craig Furman 2024-04-30 14:39:22 +01:00 committed by GitHub
parent cd0dc0cac6
commit 40da412d2c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
internal/k8s/resource/deployment/deployment.go
View File

@ -9,6 +9,11 @@ import (
// NewDeployment creates a new k8s Deployment with some default values set.
func NewDeployment(name, namespace, version string) appsv1.Deployment {
// Note that we don't set a default spec.replicas because the default is 1
// anyway, and if this field is explicitly set but also managed by an HPA,
// configuration changes will cause downscale events. Even when the HPA
// subsequently scales back out, there may have been a period of service
// disruption as requests saturate the single replica.
return appsv1.Deployment{
ObjectMeta: metav1.ObjectMeta{
Name: name,
@ -22,7 +27,6 @@ func NewDeployment(name, namespace, version string) appsv1.Deployment {
},
Spec: appsv1.DeploymentSpec{
MinReadySeconds: int32(10),
Replicas: pointers.Ptr[int32](1),
RevisionHistoryLimit: pointers.Ptr[int32](10),
Selector: &metav1.LabelSelector{
MatchLabels: map[string]string{