artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 16:31:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add double hash index for CodyGatewayDotcomUserByToken (#60695)

Browse Source 
* Add double hash index

* Write generated

* Add comment
This commit is contained in:
Rafał Gajdulewicz 2024-02-22 13:05:13 +01:00 committed by GitHub
parent f05eb84f55
commit 383b30c2d5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
8 changed files with 40 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cmd/frontend/internal/dotcom/productsubscription/tokens_db.go
View File

@ -89,6 +89,7 @@ func (e dotcomUserNotFoundError) NotFound() bool {
// LookupDotcomUserIDByAccessToken returns the userID corresponding to the given token.
// Requires the token has the DotcomUserGatewayAccessTokenPrefix, otherwise fails.
// Note: this depends on `access_tokens_lookup_double_hash` index to run efficiently, if you are modifying this function, consider changing/dropping the index.
func (t dbTokens) LookupDotcomUserIDByAccessToken(ctx context.Context, token string) (int, error) {
if !strings.HasPrefix(token, accesstoken.DotcomUserGatewayAccessTokenPrefix) {
return 0, dotcomUserNotFoundError{reason: "invalid token with unknown prefix"}
@ -108,7 +109,7 @@ func (t dbTokens) LookupDotcomUserIDByAccessToken(ctx context.Context, token str
FROM access_tokens t2
JOIN users subject_user ON t2.subject_user_id=subject_user.id AND subject_user.deleted_at IS NULL
JOIN users creator_user ON t2.creator_user_id=creator_user.id AND creator_user.deleted_at IS NULL
WHERE
WHERE
digest(value_sha256, 'sha256')=%s
AND
t2.deleted_at IS NULL

20
internal/database/migration/shared/data/stitched-migration-graph.json
View File

@ -11136,6 +11136,23 @@
],
"IsCreateIndexConcurrently": false,
"IndexMetadata": null
},
{
"ID": 1708596613,
"Name": "access_tokens_double_hash_index",
"UpQuery": "CREATE INDEX CONCURRENTLY IF NOT EXISTS access_tokens_lookup_double_hash ON access_tokens USING HASH (digest(value_sha256, 'sha256'))\n WHERE\n deleted_at IS NULL;",
"DownQuery": "DROP INDEX IF EXISTS access_tokens_lookup_double_hash;",
"Privileged": false,
"NonIdempotent": false,
"Parents": [
1695911128,
1707759188
],
"IsCreateIndexConcurrently": true,
"IndexMetadata": {
"TableName": "access_tokens",
"IndexName": "access_tokens_lookup_double_hash"
}
}
],
"BoundsByRev": {
@ -11387,8 +11404,7 @@
"v5.3.0": {
"RootID": 1648051770,
"LeafIDs": [
1695911128,
1707759188
1708596613
],
"PreCreation": false
}

10
internal/database/schema.json
View File

@ -1707,6 +1707,16 @@
"IndexDefinition": "CREATE INDEX access_tokens_lookup ON access_tokens USING hash (value_sha256) WHERE deleted_at IS NULL",
"ConstraintType": "",
"ConstraintDefinition": ""
},
{
"Name": "access_tokens_lookup_double_hash",
"IsPrimaryKey": false,
"IsUnique": false,
"IsExclusion": false,
"IsDeferrable": false,
"IndexDefinition": "CREATE INDEX access_tokens_lookup_double_hash ON access_tokens USING hash (digest(value_sha256, 'sha256'::text)) WHERE deleted_at IS NULL",
"ConstraintType": "",
"ConstraintDefinition": ""
}
],
"Constraints": [

1
internal/database/schema.md
View File

@ -39,6 +39,7 @@ Indexes:
"access_tokens_pkey" PRIMARY KEY, btree (id)
"access_tokens_value_sha256_key" UNIQUE CONSTRAINT, btree (value_sha256)
"access_tokens_lookup" hash (value_sha256) WHERE deleted_at IS NULL
"access_tokens_lookup_double_hash" hash (digest(value_sha256, 'sha256'::text)) WHERE deleted_at IS NULL
Foreign-key constraints:
"access_tokens_creator_user_id_fkey" FOREIGN KEY (creator_user_id) REFERENCES users(id)
"access_tokens_subject_user_id_fkey" FOREIGN KEY (subject_user_id) REFERENCES users(id)

1
migrations/frontend/1708596613_access_tokens_double_hash_index/down.sql Normal file
View File

@ -0,0 +1 @@
DROP INDEX IF EXISTS access_tokens_lookup_double_hash;

3
migrations/frontend/1708596613_access_tokens_double_hash_index/metadata.yaml Normal file
View File

@ -0,0 +1,3 @@
name: access_tokens_double_hash_index
parents: [1695911128, 1707759188]
createIndexConcurrently: true

3
migrations/frontend/1708596613_access_tokens_double_hash_index/up.sql Normal file
View File

@ -0,0 +1,3 @@
CREATE INDEX CONCURRENTLY IF NOT EXISTS access_tokens_lookup_double_hash ON access_tokens USING HASH (digest(value_sha256, 'sha256'))
WHERE
deleted_at IS NULL;

2
migrations/frontend/squashed.sql
View File

@ -5889,6 +5889,8 @@ CREATE INDEX access_requests_status ON access_requests USING btree (status);
CREATE INDEX access_tokens_lookup ON access_tokens USING hash (value_sha256) WHERE (deleted_at IS NULL);
CREATE INDEX access_tokens_lookup_double_hash ON access_tokens USING hash (digest(value_sha256, 'sha256'::text)) WHERE (deleted_at IS NULL);
CREATE INDEX app_id_idx ON github_app_installs USING btree (app_id);
CREATE UNIQUE INDEX assigned_owners_file_path_owner ON assigned_owners USING btree (file_path_id, owner_user_id);