artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 15:51:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(batches): remove batches-github-app-integration feature flag (#63701)

Browse Source 
We want to make the `Batch Changes <> GitHub App` integration available
for everyone.

## Test plan

<!-- REQUIRED; info at
https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles
-->
Manual testing

## Changelog

<!-- OPTIONAL; info at
https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c
-->
This commit is contained in:
Bolaji Olajide 2024-07-09 08:43:01 +01:00 committed by GitHub
parent fb1106be15
commit 2c3d92398d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
client/web/src/enterprise/batches/settings/AddCredentialModal.tsx
View File

@ -7,7 +7,6 @@ import type { AuthenticatedUser } from '@sourcegraph/shared/src/auth'
import { Button, Modal, Link, Code, Label, Text, Input, ErrorAlert, Form, Select } from '@sourcegraph/wildcard'
import { LoaderButton } from '../../../components/LoaderButton'
import { useFeatureFlag } from '../../../featureFlags/useFeatureFlag'
import { ExternalServiceKind, GitHubAppKind, type UserAreaUserFields } from '../../../graphql-operations'
import { useCreateBatchChangesCredential } from './backend'
@ -105,7 +104,6 @@ export const AddCredentialModal: FC<React.PropsWithChildren<AddCredentialModalPr
const [authStrategy, setAuthStrategy] = useState<AuthenticationStrategyType>(
AuthenticationStrategy.PERSONAL_ACCESS_TOKEN
)
const [isGithubAppIntegrationEnabled] = useFeatureFlag('batches-github-app-integration')
const onChangeCredential = useCallback<React.ChangeEventHandler<HTMLInputElement>>(event => {
setCredential(event.target.value)
@ -156,7 +154,7 @@ export const AddCredentialModal: FC<React.PropsWithChildren<AddCredentialModalPr
)
const isTokenSection = step === 'add-token'
const isGitHubKind = externalServiceKind === ExternalServiceKind.GITHUB
const isExternalServiceKindGitHub = externalServiceKind === ExternalServiceKind.GITHUB
// addCredentialModalStepRuler
return (
@ -167,7 +165,7 @@ export const AddCredentialModal: FC<React.PropsWithChildren<AddCredentialModalPr
externalServiceKind={externalServiceKind}
externalServiceURL={externalServiceURL}
/>
{isGitHubKind && isGithubAppIntegrationEnabled && isTokenSection && (
{isExternalServiceKindGitHub && isTokenSection && (
<Select
id="credential-kind"
selectSize="sm"