feat/sg/enterprise-portal: use externalSecret to configure SAMS client secret (#62953)

This commit is contained in:
Robert Lin 2024-05-28 15:27:30 -07:00 committed by GitHub
parent de9a31aa89
commit 28324a3d95
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 5 deletions

View File

@ -21,7 +21,7 @@ type SGConfigCommandOptions struct {
// Output all logs to a file instead of to stdout/stderr
Logfile string `yaml:"logfile"`
ExternalSecrets map[string]secrets.ExternalSecret `yaml:"external_secrets"`
ExternalSecrets map[string]secrets.ExternalSecret `yaml:"externalSecrets"`
RepositoryRoot string
}

View File

@ -403,9 +403,13 @@ commands:
GRPC_WEB_UI_ENABLED: 'true'
# Used for authentication
SAMS_URL: https://accounts.sgdev.org
# Set real values in sg.config.yaml overrides
ENTERPRISE_PORTAL_SAMS_CLIENT_ID: "sams_cid_put_a_real_value_in_sg.config.overwrite.yaml"
ENTERPRISE_PORTAL_SAMS_CLIENT_SECRET: "sams_cs_put_a_real_value_in_sg.config.overwrite.yaml"
# client name: 'enterprise-portal-local-dev'
ENTERPRISE_PORTAL_SAMS_CLIENT_ID: "sams_cid_018fc125-5a92-70fa-8dee-2c6df3adc100"
externalSecrets:
ENTERPRISE_PORTAL_SAMS_CLIENT_SECRET:
project: sourcegraph-local-dev
name: ENTERPRISE_PORTAL_LOCAL_SAMS_CLIENT_SECRET
watch:
- lib
- cmd/enterprise-portal
@ -1869,7 +1873,7 @@ tests:
TEST_USER_PASSWORD: supersecurepassword
SOURCEGRAPH_BASE_URL: https://sourcegraph.test:3443
BROWSER: chrome
external_secrets:
externalSecrets:
GH_TOKEN:
project: 'sourcegraph-ci'
name: 'BUILDKITE_GITHUBDOTCOM_TOKEN'