upgrade nodejs to 20.8 (#57910)

Going from version 18 to 20 means we get better perf and the built-in WebCrypto API, which makes a crypto test polyfill no longer needed.

.tool-versions

@@ -1,5 +1,5 @@
 golang 1.20.10
-nodejs 18.17.1
+nodejs 20.8.1
 fd 8.6.0
 shfmt 3.5.0
 shellcheck 0.7.1

BUILD.bazel

@@ -67,6 +67,7 @@ ts_config(
 js_library(
     name = "postcss_config_js",
     srcs = ["postcss.config.js"],
+    visibility = ["//visibility:public"],
     deps = [
         "//:node_modules/autoprefixer",
         "//:node_modules/postcss-custom-media",

WORKSPACE

@@ -23,9 +23,9 @@ http_archive(
 # rules_js defines an older rules_nodejs, so we override it here
 http_archive(
     name = "rules_nodejs",
-    sha256 = "5ad078287b5f3069735652e1fc933cb2e2189b15d2c9fc826c889dc466c32a07",
-    strip_prefix = "rules_nodejs-6.0.1",
-    url = "https://github.com/bazelbuild/rules_nodejs/releases/download/v6.0.1/rules_nodejs-v6.0.1.tar.gz",
+    sha256 = "162f4adfd719ba42b8a6f16030a20f434dc110c65dc608660ef7b3411c9873f9",
+    strip_prefix = "rules_nodejs-6.0.2",
+    url = "https://github.com/bazelbuild/rules_nodejs/releases/download/v6.0.2/rules_nodejs-v6.0.2.tar.gz",
 )
 
 http_archive(
@@ -147,7 +147,7 @@ load("@rules_nodejs//nodejs:repositories.bzl", "nodejs_register_toolchains")
 
 nodejs_register_toolchains(
     name = "nodejs",
-    node_version = "18.17.1",
+    node_version = "20.8.0",
 )
 
 # rules_js npm setup ============================

client/browser/BUILD.bazel

@@ -394,7 +394,10 @@ esbuild(
         "src/branded.css",
         "src/shared/extensionHostWorker.js",
     ],
-    deps = ["//client/browser/config"],
+    deps = [
+        "//:postcss_config_js",  #keep
+        "//client/browser/config",
+    ],
 )
 
 # Mirror `client/browser/scripts/build-inline-extensions.js`

client/browser/config/BUILD.bazel

@@ -12,6 +12,9 @@ ts_project(
         "esbuild.ts",
         "utils.ts",
     ],
+    data = [
+        "//:postcss_config_js",  #keep
+    ],
     module = "commonjs",
     tsconfig = "//client/browser:tsconfig",
     visibility = ["//client:__subpackages__"],
@@ -23,6 +26,7 @@ ts_project(
         "//:node_modules/open-color",  #keep
         "//:node_modules/path-browserify",  #keep
         "//client/browser:node_modules/@sourcegraph/build-config",
+        "//client/build-config:build-config_lib",  #keep
     ],
 )
 

client/build-config/BUILD.bazel

@@ -32,6 +32,9 @@ ts_project(
         "src/paths.ts",
         "src/utils/environment-config.ts",
     ],
+    data = [
+        "//:postcss_config_js",  #keep
+    ],
     module = "commonjs",
     tsconfig = ":tsconfig",
     deps = [

client/web/src/org/settings/profile/OrgSettingsProfilePage.tsx

@@ -29,7 +29,7 @@ export const OrgSettingsProfilePage: React.FunctionComponent<React.PropsWithChil
     }, [])
     const [isLoading, setIsLoading] = useState<boolean | Error>(false)
     const [updated, setIsUpdated] = useState<boolean>(false)
-    const [updateResetTimer, setUpdateResetTimer] = useState<NodeJS.Timer>()
+    const [updateResetTimer, setUpdateResetTimer] = useState<number>()
 
     useEffect(
         () => () => {
@@ -51,7 +51,7 @@ export const OrgSettingsProfilePage: React.FunctionComponent<React.PropsWithChil
                 setIsLoading(false)
                 setIsUpdated(true)
                 setUpdateResetTimer(
-                    setTimeout(() => {
+                    window.setTimeout(() => {
                         // Hide "updated" text again after 1s
                         setIsUpdated(false)
                     }, 1000)

package.json

@@ -7,7 +7,7 @@
     "url": "https://github.com/sourcegraph/sourcegraph"
   },
   "engines": {
-    "node": "^v18.17.1",
+    "node": "^v20.8.0",
     "pnpm": "^8.9.2"
   },
   "scripts": {
@@ -162,7 +162,7 @@
     "@types/mock-require": "^2.0.1",
     "@types/mockdate": "2.0.0",
     "@types/mz": "2.7.3",
-    "@types/node": "18.17.15",
+    "@types/node": "20.8.0",
     "@types/node-fetch": "2.5.10",
     "@types/pollyjs__adapter": "4.3.0",
     "@types/pollyjs__core": "4.3.1",

wolfi-images/cloud-mi2.yaml

@@ -10,7 +10,7 @@ contents:
     - terraform@sourcegraph
     - helm=3.11.3-r1
     - kustomize=4.5.7-r0
-    - nodejs-18=18.17.1-r1
+    - nodejs-20=20.9.0
     - kubectl-1.24=1.24.17-r1
     - kubectl-1.24-default=1.24.17-r1
     - gke-gcloud-auth-plugin@sourcegraph