change page head name from 'commits' to 'changelists' when applicable.

This commit is contained in:
Jason Harris 2024-08-05 15:39:43 -05:00
parent 51685f116e
commit 1cb58b8ada
3 changed files with 6 additions and 4 deletions

View File

@ -17,7 +17,7 @@
export let name: string
export let seeAllItemsURL: string
export let getData: ((query: string) => PromiseLike<Result<T>>) | (() => PromiseLike<Result<T>>)
export let getData: (query: string) => PromiseLike<Result<T>>
export let onSelect: (item: T) => void
export let toOption: (item: T) => ComboboxOptionProps<string>
@ -52,6 +52,7 @@
})
}
$: filteredData = $data.value ? $data.value.nodes : []
$: console.log('filtered data:', $filteredData)
</script>
<div class="root" data-picker-root>

View File

@ -58,6 +58,7 @@
defaultBranch: string
display?: ComponentProps<ButtonGroup>['display']
placement?: Placement
isPerforceDepot?: boolean
onSelect?: (revision: string) => void
getRepositoryTags: (query: string) => PromiseLike<RepositoryTags>
getRepositoryCommits: (query: string) => PromiseLike<RepositoryCommits>
@ -70,6 +71,7 @@
export let commitID: $$Props['commitID'] = undefined
export let defaultBranch: $$Props['defaultBranch']
export let placement: $$Props['placement'] = 'right-start'
export let isPerforceDepot: $$Props['isPerforceDepot'] = false
export let display: $$Props['display'] = undefined
/**
* Optional handler for revision selection.
@ -93,7 +95,6 @@
$: isOnSpecificRev = revisionLabel !== defaultBranch
const buttonClass = getButtonClassName({ variant: 'secondary', outline: false, size: 'sm' })
$: isPerforceDepot = getDepotChangelists !== null
</script>
<Popover let:registerTrigger let:registerTarget let:toggle {placement}>
@ -290,7 +291,6 @@
}
}
.commit-subject,
.changelist-subject {
overflow: hidden;
text-overflow: ellipsis;

View File

@ -43,7 +43,7 @@
$: changelistsQuery = data.changelistsQuery
$: changelists = $changelistsQuery.data
$: pageTitle = (() => {
const parts = ['Commits']
const parts = ['Changelists']
if (data.path) {
parts.push(data.path)
}
@ -70,6 +70,7 @@
commitID={data.resolvedRevision.commitID}
defaultBranch={data.defaultBranch}
placement="bottom-start"
isPerforceDepot={data.isPerforceDepot}
getRepositoryBranches={data.getRepoBranches}
getRepositoryCommits={data.getRepoCommits}
getRepositoryTags={data.getRepoTags}