mirror of
https://github.com/sourcegraph/sourcegraph.git
synced 2026-02-06 15:31:48 +00:00
fix(batches): the baseURL for github instance is now updated when creating a GitHub app (#63803)
Closes SRCH-723 The baseURL for GitHub apps defaults to `https://github.com` when no `externalServiceURL`, we somehow missed this during our testing.  ## Test plan <!-- REQUIRED; info at https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles --> Manual testing with the GHE instance. ## Changelog <!-- OPTIONAL; info at https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c -->
This commit is contained in:
parent
aaee245a31
commit
1c40c9e5bc
@ -383,6 +383,7 @@ const AddToken: FC<AddTokenProps> = ({
|
||||
authenticatedUser={user as unknown as AuthenticatedUser}
|
||||
minimizedMode={true}
|
||||
kind={kind}
|
||||
externalServiceURL={externalServiceURL}
|
||||
/>
|
||||
)}
|
||||
</>
|
||||
|
||||
@ -23,16 +23,18 @@ interface BatchChangesCreateGitHubAppPageProps {
|
||||
authenticatedUser: AuthenticatedUser
|
||||
minimizedMode?: boolean
|
||||
kind: GitHubAppKind
|
||||
externalServiceURL?: string
|
||||
}
|
||||
|
||||
export const BatchChangesCreateGitHubAppPage: FC<BatchChangesCreateGitHubAppPageProps> = ({
|
||||
minimizedMode,
|
||||
kind,
|
||||
authenticatedUser,
|
||||
externalServiceURL,
|
||||
}) => {
|
||||
const location = useLocation()
|
||||
const searchParams = new URLSearchParams(location.search)
|
||||
const baseURL = searchParams.get('baseURL')
|
||||
const baseURL = externalServiceURL || searchParams.get('baseURL')
|
||||
|
||||
const isGitHubAppKindCredential = kind === GitHubAppKind.USER_CREDENTIAL || kind === GitHubAppKind.SITE_CREDENTIAL
|
||||
|
||||
|
||||
Loading…
Reference in New Issue
Block a user