artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 18:51:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

grpc: gitserver: use generated getters to access fields for BatchLog (#54194)

Browse Source 
Using the generated getters protects against the request itself being
nil (which is possible since all fields are optional in protobuf 3).



## Test plan

Unit tests
This commit is contained in:
Geoffrey Gilmore 2023-06-26 13:25:44 -07:00 committed by GitHub
parent b561cc3b1b
commit 14ae91ece7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
cmd/gitserver/server/server_grpc.go
View File

@ -33,18 +33,19 @@ type GRPCServer struct {
func (gs *GRPCServer) BatchLog(ctx context.Context, req *proto.BatchLogRequest) (*proto.BatchLogResponse, error) {
gs.Server.operations = gs.Server.ensureOperations()
var internalReq protocol.BatchLogRequest
internalReq.FromProto(req)
// Validate request parameters
if len(req.RepoCommits) == 0 {
if len(req.GetRepoCommits()) == 0 {
return &proto.BatchLogResponse{}, nil
}
if !strings.HasPrefix(req.Format, "--format=") {
if !strings.HasPrefix(req.GetFormat(), "--format=") {
return nil, status.Error(codes.InvalidArgument, "format parameter expected to be of the form `--format=<git log format>`")
}
var r protocol.BatchLogRequest
r.FromProto(req)
// Handle unexpected error conditions
resp, err := gs.Server.batchGitLogInstrumentedHandler(ctx, internalReq)
resp, err := gs.Server.batchGitLogInstrumentedHandler(ctx, r)
if err != nil {
return nil, status.Error(codes.Internal, err.Error())
}