artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 19:21:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

web: Fix syncing feature flag overrides from URL (#57926)

Browse Source 
I've changed this code a couple of times between returning an object and a map and it seems I left it in a bad state (overrideFeatureFlags returns a map).
This commit is contained in:
Felix Kling 2023-10-27 19:17:15 +02:00 committed by GitHub
parent cbc57a7e56
commit 140d93ba25
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
client/web/src/featureFlags/FeatureFlagsProvider.tsx
View File

@ -9,7 +9,6 @@ import { parseUrlOverrideFeatureFlags } from './lib/parseUrlOverrideFeatureFlags
/**
* Overrides feature flag based on initial URL query parameters
*
* @description
* Enable: "/?feat=my-feature"
* Disable: "/?feat=-my-feature"
@ -20,11 +19,11 @@ export const FeatureFlagsLocalOverrideAgent: FC<PropsWithChildren<{}>> = ({ chil
useEffect(() => {
try {
const overrideFeatureFlags = parseUrlOverrideFeatureFlags(location.search)
for (const [flagName, value] of Object.entries(overrideFeatureFlags)) {
if (!value) {
removeFeatureFlagOverride(flagName)
} else {
for (const [flagName, value] of overrideFeatureFlags) {
if (value !== null) {
setFeatureFlagOverride(flagName, value)
} else {
removeFeatureFlagOverride(flagName)
}
}
// Update override counter to notify/update the developer settings