artin/sourcegraph
1
0
Fork 0
mirror of https://github.com/sourcegraph/sourcegraph.git synced 2026-02-06 16:51:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

ci: error handle story book build fail (#52428)

Browse Source 
Automatically fail Buildkite build step `:chromatic: Upload Storybook to
Chromatic` if Chromatic storybook build fails.

Previously, if the Chromatic deployment failed to build for some reason,
the build would still succeed. Making the report unreliable

This change adds a check to see if the `pnpm chromatic` exit status is
non zero, and If so, the script will immediately exit with a failure,
causing the Buildkite build to be marked as failed.

context:
https://sourcegraph.slack.com/archives/C04MYFW01NV/p1684969967117259

## Test plan
ci 
<!-- All pull requests REQUIRE a test plan:
https://docs.sourcegraph.com/dev/background-information/testing_principles
-->
This commit is contained in:
Manuel Ucles 2023-05-24 20:29:42 -07:00 committed by GitHub
parent 60d130de3b
commit 0004d6410a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dev/ci/post-chromatic.sh
View File

@ -10,8 +10,16 @@ set -eu -o pipefail
# - BUILDKITE_PULL_REQUEST
# - RENDER_PREVIEW_GITHUB_TOKEN
exit_status=$?
chromatic_publish_output=$(</dev/stdin)
if [ $exit_status -eq 0 ]; then
echo "$chromatic_publish_output"
else
echo "$chromatic_publish_output"
exit 1
fi
echo "$chromatic_publish_output"
# Chromatic preview url from Chromatic publish output (`-m 1` for getting first match)