From ea8d46c4a1133a5ec2e78d66712877d07f68e186 Mon Sep 17 00:00:00 2001 From: BJ Dierkes Date: Mon, 13 Aug 2018 12:33:48 -0500 Subject: [PATCH] Fix Tests / Coverage --- cement/utils/misc.py | 4 ++-- tests/utils/test_misc.py | 18 +++++++++--------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/cement/utils/misc.py b/cement/utils/misc.py index adbf6e03..1f520977 100644 --- a/cement/utils/misc.py +++ b/cement/utils/misc.py @@ -186,10 +186,10 @@ def is_true(item): """ if isinstance(item, str) and item.lower() in ['true', 'yes', 'on', '1']: return True - elif isinstance(item, int) and item == 1: - return True elif isinstance(item, bool) and item is True: return True + elif isinstance(item, int) and item == 1: + return True else: return False diff --git a/tests/utils/test_misc.py b/tests/utils/test_misc.py index 433818ff..af55213c 100644 --- a/tests/utils/test_misc.py +++ b/tests/utils/test_misc.py @@ -19,15 +19,15 @@ def test_is_true(): assert misc.is_true(True) # false - assert misc.is_true(0) - assert misc.is_true('0') - assert misc.is_true('false') - assert misc.is_true('False') - assert misc.is_true('FALSE') - assert misc.is_true('fAlse') - assert misc.is_true('no') - assert misc.is_true('off') - assert misc.is_true(False) + assert not misc.is_true(0) + assert not misc.is_true('0') + assert not misc.is_true('false') + assert not misc.is_true('False') + assert not misc.is_true('FALSE') + assert not misc.is_true('fAlse') + assert not misc.is_true('no') + assert not misc.is_true('off') + assert not misc.is_true(False) def test_defaults():