From 560737554aa3f8f5cd9013d35ff3911f0f8697b5 Mon Sep 17 00:00:00 2001 From: BJ Dierkes Date: Fri, 3 Aug 2012 16:14:33 -0500 Subject: [PATCH] Resolves Issue #155 --- ChangeLog | 5 +++++ cement/core/exc.py | 9 --------- tests/core/exc_tests.py | 18 ------------------ 3 files changed, 5 insertions(+), 27 deletions(-) diff --git a/ChangeLog b/ChangeLog index c268fbdb..16410f7a 100755 --- a/ChangeLog +++ b/ChangeLog @@ -54,6 +54,11 @@ Incompatible Changes: * Removed cement.handler.enabled(). Now use `handler.registered()` instead. +Misc: + + * :issue:`155` - Removed unused CementArgumentError, and + CementConfigError. These types of exceptions should be defined at + the application level. 1.9.14 - Sun Jul 16, 2012 ------------------------------------------------------------------------------ diff --git a/cement/core/exc.py b/cement/core/exc.py index a0cb7537..1ac92178 100644 --- a/cement/core/exc.py +++ b/cement/core/exc.py @@ -14,21 +14,12 @@ class CementError(Exception): def __str__(self): return self.msg - -class CementConfigError(CementError): - """Cement configuration related errors.""" - pass - class CementRuntimeError(CementError): """ General runtime errors. Similar to '500 Internal Server Error' in the web world. """ pass - -class CementArgumentError(CementError): - """Command line argument related errors.""" - pass class CementInterfaceError(CementError): """Interface related errors.""" diff --git a/tests/core/exc_tests.py b/tests/core/exc_tests.py index 995c188c..7d3ead50 100644 --- a/tests/core/exc_tests.py +++ b/tests/core/exc_tests.py @@ -4,15 +4,6 @@ from cement.core import exc from cement.utils import test class ExceptionTestCase(test.CementTestCase): - @test.raises(exc.CementConfigError) - def test_cement_config_error(self): - try: - raise exc.CementConfigError("CementConfigError Test") - except exc.CementConfigError as e: - self.eq(e.msg, "CementConfigError Test") - self.eq(e.__str__(), "CementConfigError Test") - raise - @test.raises(exc.CementRuntimeError) def test_cement_runtime_error(self): try: @@ -22,15 +13,6 @@ class ExceptionTestCase(test.CementTestCase): self.eq(e.__str__(), "CementRuntimeError Test") raise - @test.raises(exc.CementArgumentError) - def test_cement_argument_error(self): - try: - raise exc.CementArgumentError("CementArgumentError Test") - except exc.CementArgumentError as e: - self.eq(e.msg, "CementArgumentError Test") - self.eq(e.__str__(), "CementArgumentError Test") - raise - @test.raises(exc.CementInterfaceError) def test_cement_interface_error(self): try: