artin/Rocket
1
0
Fork 0
mirror of https://github.com/SergioBenitez/Rocket.git synced 2026-02-06 10:48:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update diesel-async to 0.6, and remove an unnecessary Sync bound (#2972)

Browse Source 
The `Sync` bound on `Pool` is, as far as I can tell, unneeded.
`diesel-async`'s mysql connection pool isn't `Sync` anymore,
which is why bound needed to be removed.

closes: #2969
This commit is contained in:
Matthew Pomes 2025-12-27 21:47:16 -06:00 committed by GitHub
parent 504efef179
commit 3ccfd8bd77
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/db_pools/lib/Cargo.toml
View File

@ -64,7 +64,7 @@ features = ["compat-3-0-0", "rustls-tls"]
optional = true
[dependencies.diesel-async]
version = "0.5.0"
version = "0.6.0"
default-features = false
features = ["async-connection-wrapper"]
optional = true

6
contrib/db_pools/lib/src/pool.rs
View File

@ -114,7 +114,7 @@ use {std::time::Duration, crate::{Error, Config}};
/// }
/// ```
#[rocket::async_trait]
pub trait Pool: Sized + Send + Sync + 'static {
pub trait Pool: Sized + Send + 'static {
/// The connection type managed by this pool, returned by [`Self::get()`].
type Connection;
@ -160,7 +160,7 @@ mod deadpool_postgres {
#[cfg(feature = "diesel")]
use diesel_async::pooled_connection::AsyncDieselConnectionManager;
pub trait DeadManager: Manager + Sized + Send + Sync + 'static {
pub trait DeadManager: Manager + Sized + Send + 'static {
fn new(config: &Config) -> Result<Self, Self::Error>;
}
@ -194,7 +194,7 @@ mod deadpool_postgres {
#[rocket::async_trait]
impl<M: DeadManager, C: From<Object<M>>> crate::Pool for Pool<M, C>
where M::Type: Send, C: Send + Sync + 'static, M::Error: std::error::Error
where M::Type: Send, C: Send + 'static, M::Error: std::error::Error
{
type Error = Error<PoolError<M::Error>>;